Add App Engine flex new project wizard #2546
Conversation
|
|
||
| flex.jar.wizard.name=Google App Engine Flexible Java JAR Project | ||
| flex.jar.wizard.description=Creates an App Engine Flexible Java project whose deploy artifact is a \ | ||
| runnable "fat" Java archive (JAR). |
There was a problem hiding this comment.
I think just "fat" JAR is fine; i.e. don't need to spell out Java archive. Better yet
"Creates an App Engine Flexible Java project for the Java runtime" though I do wish the App Engine team would give these runtimes better names.
| flex.wizard.description=Creates an App Engine Flexible Java project. | ||
| flex.war.wizard.name=Google App Engine Flexible Java WAR Project | ||
| flex.war.wizard.description=Creates an App Engine Flexible Java project whose deploy artifact is a \ | ||
| web application archive (WAR). |
There was a problem hiding this comment.
WAR file; don't spell out web application archive; and you know; let's focus on the runtime here; not the deploy artifact. I.e. something like
"Creates an App Engine Flexible Java project for the Jetty runtime"
There was a problem hiding this comment.
But we have a Tomcat runtime too. Deployable with "gcloud beta": https://github.com/GoogleCloudPlatform/tomcat-runtime#cloud-sdk.
There was a problem hiding this comment.
Perhaps "the Jetty/Tomcat runtime" will do.
| @@ -26,6 +27,9 @@ deploy.assembly.test.source.remove.job=Removing test Java source folder from web | |||
| CREATE_AS_MAVEN_PROJECT=Create as Maven project | |||
| MAVEN_PROJECT_COORDINATES=Maven project coordinates | |||
| GROUP_ID=Group ID: | |||
| FLEX_JAR_SAMPLE_TEMPLATE=Sample template: | |||
| FLEX_JAR_SIMPLE_TEMPLATE=simple | |||
There was a problem hiding this comment.
I'm not sure "simple" is the right description here; though I'm not sure what is. Maybe Minimal? No Dependencies?
Ideally I'd like to replace this template with a Jetty based template, but I'm not sure we have time to do that.
There was a problem hiding this comment.
No Web Framework?
It's easy to add a Jetty template, BTW.
Codecov Report
@@ Coverage Diff @@
## chanseok-wip #2546 +/- ##
==================================================
+ Coverage 72.63% 72.67% +0.03%
- Complexity 2381 2396 +15
==================================================
Files 348 350 +2
Lines 13911 13963 +52
Branches 1389 1389
==================================================
+ Hits 10104 10147 +43
- Misses 3240 3250 +10
+ Partials 567 566 -1
Continue to review full report at Codecov.
|
| fail(); | ||
| } | ||
|
|
||
| private boolean containsSegment(IPath path, String segment) { |
| flex.wizard.name=Google App Engine Flexible Java Project | ||
| flex.wizard.description=Creates an App Engine Flexible Java project. | ||
| flex.war.wizard.name=Google App Engine Flexible Java WAR Project | ||
| flex.war.wizard.description=Creates an App Engine Flexible Java project for the Jetty or Tomcat \ |
There was a problem hiding this comment.
see email I sent you off-Github re Tomcat.
There was a problem hiding this comment.
My 2¢: repeating "App Engine Flexible Java project" in the WAR and JAR descriptions doesn't help. This WAR description should mention "servlet-based", and the JAR description should mention "runnable jar".
Fixes #2470.
This is a heads-up. It is based on #2545, so #2545 must go first. Also, I haven't added any tests. Changes in tes test files ATM are due to refactoring.
The wizard has a combo to select a sample template. Spring Boot is one of two choices.
Everything seems to work end to end, but I need to more extensive testing.