Add test for ingress-custom-grpc-health-check #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sawsa307
commented
Oct 19, 2023
sawsa307
commented
- Update SSL policy name in the recipe README and yaml to avoid naming collision.
- Add a helper function to check if a string has the expected pattern count.
- Update instance image version since the official docker install script doesn't work for debian-11.
- Add test for ingress-grpc recipe. The traffic is validated by running a grpc-client image on a docker and send grpc request to the load balancer IP.
* Update SSL policy name in the recipe README and yaml to avoid naming collision. * Add a helper function to check if a string has the expected pattern count. * Update instance image version since the offical docker install script doesn't work for debian-11. * Add test for ingress-grpc recipe. The traffic is validated by running a grpc-client image on a docker and send grpc request to the load balancer IP.
sawsa307
force-pushed
the
ingress-grpc-test
branch
from
e3640f9 to
2c29e0b
Compare
bowei
reviewed
Oct 25, 2023
| eval_cmd="gcloud compute ssh "${instance}" --zone="${zone}" -- \ | ||
| '{ docker --version || \ | ||
| (curl -fsSL https://get.docker.com -o get-docker.sh && sudo sh get-docker.sh); } > /dev/null && \ | ||
| sudo ${eval_cmd}'" |
There was a problem hiding this comment.
Is there a way to do this without having to install docker? Is there a debian package that offers a grpc_client?
bowei
reviewed
Oct 25, 2023
| eval_cmd="docker run \ | ||
| --add-host grpc.domain.com:${vip} \ | ||
| -t \ | ||
| docker.io/salrashid123/grpc_app /grpc_client \ |
There was a problem hiding this comment.
we should not use random containers on the Internet in our tests.
There was a problem hiding this comment.
It is a security and reliability issue
There was a problem hiding this comment.
This is described in the README so I follow within the test.
I'll look for ways to validate using an official image for grpc_client or using grpcurl.
|
Closing this since it is not maintainable to use custom hosted image. Will follow up with test author to update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.