Add test for ingress iap. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sawsa307
commented
Oct 18, 2023
sawsa307
commented
- Add test for ingress iap.
- In the test, OAuth credential will be genereated and used in kubectl secret.
- User needs to have a valid domain name and specify DNS record as environment variable. A valid support email is also needed if OAuth Brand doesn't exist in the running project.
sawsa307
force-pushed
the
ingress-iap-test
branch
3 times, most recently
from
e2e11e6 to
d88ba47
Compare
sawsa307
force-pushed
the
ingress-iap-test
branch
from
d88ba47 to
2e0ee97
Compare
* Add test for ingress iap. * In the test, OAuth credential will be genereated and used in kubectl secret. * User needs to have a valid domain name and specify DNS record as environment variable. A valid support email is also needed if OAuth Brand doesn't exist in the running project.
sawsa307
force-pushed
the
ingress-iap-test
branch
from
2e0ee97 to
c79f083
Compare
bowei
approved these changes
Oct 30, 2023
|
|
||
| resource_yaml="ingress/single-cluster/ingress-iap/iap-ingress.yaml" | ||
| kubectl --context "${context}" delete -f "${resource_yaml}" -n "${test_name}" || true | ||
| sed -i'.bak' "s/${iap_dns_record}/\$DOMAIN/g" "${resource_yaml}" |
There was a problem hiding this comment.
you can fix this in a follow on commit, but we should try to not modify inside the original source director.
ideally you put the temp files in a directory returned by mktemp -d and delete the temporary directory with an EXIT trap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.