Add test for ingress-nginx. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sawsa307
commented
Oct 18, 2023
sawsa307
commented
- Add test for ingress-nginx.
- Add clarification in README that GKE is not responsible for nginx controller issue.
sawsa307
force-pushed
the
ingress-nginx-test
branch
3 times, most recently
from
cc5047e to
62c3acf
Compare
* Add test for ingress-nginx. * Add clarification in README that GKE is not responsible for nginx controller issue. * In setup.sh, we need to wait for webhook to be fully set up before applying the ingress yaml.
sawsa307
force-pushed
the
ingress-nginx-test
branch
from
62c3acf to
83643bb
Compare
|
/lgtm |
bowei
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.