makes enable-hns default false (#2395)

* makes enable-hns default false * makes enable-hns default false * makes enable-hns default false * fixes config test * checking flakiness
GoogleCloudPlatform · Aug 27, 2024 · c36327d · c36327d
1 parent a80dd0d
commit c36327d
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/cfg/config.go b/cfg/config.go
@@ -357,7 +357,7 @@ func BindFlags(v *viper.Viper, flagSet *pflag.FlagSet) error {
 		return err
 	}
 
-	flagSet.BoolP("enable-hns", "", true, "Enables support for HNS buckets")
+	flagSet.BoolP("enable-hns", "", false, "Enables support for HNS buckets")
 
 	if err := v.BindPFlag("enable-hns", flagSet.Lookup("enable-hns")); err != nil {
 		return err

diff --git a/cmd/config_validation_test.go b/cmd/config_validation_test.go
@@ -551,14 +551,14 @@ func TestValidateConfigFile_EnableHNSConfigSuccessful(t *testing.T) {
 			name:       "empty_config_file",
 			configFile: "testdata/empty_file.yaml",
 			expectedConfig: &cfg.Config{
-				EnableHns: true,
+				EnableHns: false,
 			},
 		},
 		{
 			name:       "valid_config_file",
 			configFile: "testdata/valid_config.yaml",
 			expectedConfig: &cfg.Config{
-				EnableHns: false,
+				EnableHns: true,
 			},
 		},
 	}

diff --git a/cmd/root_test.go b/cmd/root_test.go
@@ -741,7 +741,7 @@ func TestArgsParsing_EnableHNSFlags(t *testing.T) {
 		{
 			name:              "default",
 			args:              []string{"gcsfuse", "abc", "pqr"},
-			expectedEnableHNS: true,
+			expectedEnableHNS: false,
 		},
 	}
 

diff --git a/cmd/testdata/valid_config.yaml b/cmd/testdata/valid_config.yaml
@@ -41,4 +41,4 @@ file-system:
   temp-dir: ~/temp
 list:
   enable-empty-managed-folders: true
-enable-hns: false
+enable-hns: true
diff --git a/internal/config/mount_config.go b/internal/config/mount_config.go
@@ -43,7 +43,7 @@ const (
 	DefaultEnableEmptyManagedFoldersListing = false
 	DefaultGrpcConnPoolSize                 = 1
 	DefaultAnonymousAccess                  = false
-	DefaultEnableHNS                        = true
+	DefaultEnableHNS                        = false
 	DefaultIgnoreInterrupts                 = true
 	DefaultPrometheusPort                   = 0
 

diff --git a/internal/config/yaml_parser_test.go b/internal/config/yaml_parser_test.go
@@ -52,7 +52,7 @@ func validateDefaultConfig(t *testing.T, mountConfig *MountConfig) {
 	assert.Equal(t, false, mountConfig.FileCacheConfig.DisableODirect)
 	assert.Equal(t, 1, mountConfig.GCSConnection.GRPCConnPoolSize)
 	assert.False(t, mountConfig.GCSAuth.AnonymousAccess)
-	assert.True(t, bool(mountConfig.EnableHNS))
+	assert.False(t, bool(mountConfig.EnableHNS))
 	assert.True(t, mountConfig.FileSystemConfig.IgnoreInterrupts)
 	assert.False(t, mountConfig.FileSystemConfig.DisableParallelDirops)
 	assert.Equal(t, DefaultKernelListCacheTtlSeconds, mountConfig.KernelListCacheTtlSeconds)

diff --git a/tools/config-gen/params.yaml b/tools/config-gen/params.yaml
@@ -61,7 +61,7 @@
   flag-name: "enable-hns"
   type: "bool"
   usage: "Enables support for HNS buckets"
-  default: true
+  default: false
 
 - config-path: "file-cache.cache-file-for-range-read"
   flag-name: "cache-file-for-range-read"