Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for clean target to remove gcluster binary and the ghpc… #3577

Merged

Conversation

nadig-google
Copy link

@nadig-google nadig-google commented Jan 22, 2025

This CL updates the Makefile to add a "clean" make target. Running "make clean" will remove the regular file "gcluster" and the symlink "ghpc" (links to gcluster).

This PR to removes the build targets from the following directories after checking if the files exist and if it has permissions to delete them:

  • current dir
  • ~/bin
  • /usr/local/bin

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@nadig-google nadig-google added the enhancement New feature or request label Jan 22, 2025
@nadig-google
Copy link
Author

Added label

Makefile Outdated Show resolved Hide resolved
@abbas1902 abbas1902 assigned nadig-google and unassigned abbas1902 Jan 22, 2025
@nadig-google nadig-google assigned mr0re1 and unassigned nadig-google Jan 23, 2025
@abbas1902 abbas1902 assigned nadig-google and unassigned mr0re1 Jan 23, 2025
@nadig-google nadig-google added the release-improvements Added to release notes under the "Improvements" heading. label Jan 23, 2025
@nadig-google nadig-google assigned mr0re1 and abbas1902 and unassigned nadig-google Jan 23, 2025
Copy link
Contributor

@abbas1902 abbas1902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbas1902 abbas1902 assigned nadig-google and unassigned mr0re1 and abbas1902 Jan 24, 2025
@nadig-google nadig-google merged commit bf8351a into GoogleCloudPlatform:develop Jan 24, 2025
9 of 54 checks passed
@nadig-google nadig-google deleted the update_makefile branch January 24, 2025 19:28
@nadig-google nadig-google restored the update_makefile branch January 24, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants