Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codegen-cluster.yaml #3569

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

ahsan518
Copy link

Create codegen-cluster.yaml file for the creation of codegen gke cluster through cluster toolkit

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

Create codegen-cluster.yaml file for the creation of codegen gke cluster through cluster toolkit
Copy link

google-cla bot commented Jan 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta comment :

  • Create a new folder in community/examples/intel
  • Move this file to the above folder
  • Add the codegen.yaml file there.
  • Please update manual test cases that were done.


blueprint_name: codegen-cluster

# tags = ["gke-no-external-ip"] ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

# tags = ["gke-no-external-ip"] ?

vars:
project_id: sada-intel-opea-automation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the name of the project, and replace with PROJECT_ID

vars:
project_id: sada-intel-opea-automation
deployment_name: codegen-cluster
region: us-east4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove us-east and replace with REGION

project_id: sada-intel-opea-automation
deployment_name: codegen-cluster
region: us-east4
authorized_cidr: 0.0.0.0/0 #probably this 10.3.0.0/28
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with authorized_cidr : <IP_CIDR> # Range of IP Addresses that should have access to the cluster

examples/codegen-cluster.yaml Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file must not be stored directly in community/examples as it will appear to be a blueprint to most users and to our validation tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants