-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create codegen-cluster.yaml #3569
base: develop
Are you sure you want to change the base?
Conversation
Create codegen-cluster.yaml file for the creation of codegen gke cluster through cluster toolkit
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meta comment :
- Create a new folder in
community/examples/intel
- Move this file to the above folder
- Add the
codegen.yaml
file there. - Please update manual test cases that were done.
examples/codegen-cluster.yaml
Outdated
|
||
blueprint_name: codegen-cluster | ||
|
||
# tags = ["gke-no-external-ip"] ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment
examples/codegen-cluster.yaml
Outdated
# tags = ["gke-no-external-ip"] ? | ||
|
||
vars: | ||
project_id: sada-intel-opea-automation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the name of the project, and replace with PROJECT_ID
examples/codegen-cluster.yaml
Outdated
vars: | ||
project_id: sada-intel-opea-automation | ||
deployment_name: codegen-cluster | ||
region: us-east4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove us-east and replace with REGION
examples/codegen-cluster.yaml
Outdated
project_id: sada-intel-opea-automation | ||
deployment_name: codegen-cluster | ||
region: us-east4 | ||
authorized_cidr: 0.0.0.0/0 #probably this 10.3.0.0/28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with authorized_cidr : <IP_CIDR>
# Range of IP Addresses that should have access to the cluster
community/examples/codegen.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file must not be stored directly in community/examples as it will appear to be a blueprint to most users and to our validation tests.
Create codegen-cluster.yaml file for the creation of codegen gke cluster through cluster toolkit
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.