Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minimum terraform version in Makefile from 1.2 to 1.5.7 #3526

Conversation

RachaelSTamakloe
Copy link
Collaborator

@RachaelSTamakloe RachaelSTamakloe commented Jan 10, 2025

This PR updates the MIN_TERRAFORM_VERSION in Makefile from v1.2 to v1.5.7 as documented here.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-version-updates Added to release notes under the "Version Updates" heading. label Jan 10, 2025
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observe the proper warning after installing Terraform 1.5.6 and Terraform 1.2.0:

~/cluster-toolkit (min_terraform_version)❯❯❯ make && make install
Makefile:153: WARNING: terraform version must be greater than 1.5.7 , update at https://learn.hashicorp.com/tutorials/terraform/install-cli

I do not observe this on latest (1.10.4) or 1.5.7.

@RachaelSTamakloe RachaelSTamakloe merged commit 14c72ac into GoogleCloudPlatform:develop Jan 13, 2025
9 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-updates Added to release notes under the "Version Updates" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants