Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into develop #3515

Merged
merged 2 commits into from
Jan 9, 2025

Merge pull request #3508 from tpdownes/hotfix-future-reservation

484da6e
Select commit
Loading
Failed to load commit list.
Merged

Merge main into develop #3515

Merge pull request #3508 from tpdownes/hotfix-future-reservation
484da6e
Select commit
Loading
Failed to load commit list.
Google Cloud Build / PR-validation (hpc-toolkit-dev) failed Jan 9, 2025 in 3m 7s

Summary

Build Information

Trigger PR-validation
Build e8f2ecba-7527-4dc3-aaad-14504bcf8075
Start 2025-01-09T09:12:30-08:00
Duration 2m15.37s
Status FAILURE

Steps

Step Status Duration
git-fetch-unshallow SUCCESS 4.252s
make-tests FAILURE 2m7.222s

Details

starting build "e8f2ecba-7527-4dc3-aaad-14504bcf8075"

FETCHSOURCE
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: 	git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: 	git branch -m <name>
Initialized empty Git repository in /workspace/.git/
From https://github.com/GoogleCloudPlatform/cluster-toolkit
 * branch            484da6e38b51d930af61c93d9e7ecf90d16aaaa6 -> FETCH_HEAD
HEAD is now at 484da6e Merge pull request #3508 from tpdownes/hotfix-future-reservation
GitCommit:
484da6e38b51d930af61c93d9e7ecf90d16aaaa6
SETUPBUILD
BUILD
Starting Step #0 - "git-fetch-unshallow"
Step #0 - "git-fetch-unshallow": Already have image (with digest): gcr.io/cloud-builders/git
Step #0 - "git-fetch-unshallow": From https://github.com/GoogleCloudPlatform/cluster-toolkit
Step #0 - "git-fetch-unshallow":  * [new branch]        a3ultra-preview       -> origin/a3ultra-preview
Step #0 - "git-fetch-unshallow":  * [new branch]        chdu                  -> origin/chdu
Step #0 - "git-fetch-unshallow":  * [new branch]        develop               -> origin/develop
Step #0 - "git-fetch-unshallow":  * [new branch]        experimental          -> origin/experimental
Step #0 - "git-fetch-unshallow":  * [new branch]        fix/ubuntu-parallelstore -> origin/fix/ubuntu-parallelstore
Step #0 - "git-fetch-unshallow":  * [new branch]        main                  -> origin/main
Step #0 - "git-fetch-unshallow":  * [new branch]        revert-3239-do_not_use_toolkit_modules_yet -> origin/revert-3239-do_not_use_toolkit_modules_yet
Step #0 - "git-fetch-unshallow":  * [new branch]        sc23                  -> origin/sc23
Step #0 - "git-fetch-unshallow":  * [new branch]        split-deployment-vars -> origin/split-deployment-vars
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.44.2               -> v1.44.2
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.1.0-alpha          -> v0.1.0-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.1.1-alpha          -> v0.1.1-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.2.0-alpha          -> v0.2.0-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.2.1-alpha          -> v0.2.1-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.2.2-alpha          -> v0.2.2-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.3.0-alpha          -> v0.3.0-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.3.1-alpha          -> v0.3.1-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.4.0-alpha          -> v0.4.0-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.5.0-alpha          -> v0.5.0-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.6.0-alpha          -> v0.6.0-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.7.0-alpha          -> v0.7.0-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.7.1-alpha          -> v0.7.1-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v0.7.2-alpha          -> v0.7.2-alpha
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.0.0                -> v1.0.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.1.0                -> v1.1.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.10.0               -> v1.10.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.10.1               -> v1.10.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.11.0               -> v1.11.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.12.0               -> v1.12.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.13.0               -> v1.13.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.14.0               -> v1.14.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.14.1               -> v1.14.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.15.0               -> v1.15.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.16.0               -> v1.16.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.17.0               -> v1.17.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.18.0               -> v1.18.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.18.1               -> v1.18.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.19.0               -> v1.19.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.19.1               -> v1.19.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.2.0                -> v1.2.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.2.1                -> v1.2.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.20.0               -> v1.20.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.21.0               -> v1.21.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.22.0               -> v1.22.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.22.1               -> v1.22.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.23.0               -> v1.23.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.24.0               -> v1.24.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.25.0               -> v1.25.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.26.0               -> v1.26.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.26.1               -> v1.26.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.27.0               -> v1.27.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.28.1               -> v1.28.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.29.0               -> v1.29.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.3.0                -> v1.3.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.30.0               -> v1.30.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.31.0               -> v1.31.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.31.1               -> v1.31.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.32.0               -> v1.32.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.32.1               -> v1.32.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.33.0               -> v1.33.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.34.0               -> v1.34.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.34.1               -> v1.34.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.34.2               -> v1.34.2
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.34.3               -> v1.34.3
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.35.0               -> v1.35.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.35.1               -> v1.35.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.36.0               -> v1.36.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.36.1               -> v1.36.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.37.0               -> v1.37.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.37.1               -> v1.37.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.37.2               -> v1.37.2
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.38.0               -> v1.38.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.39.0               -> v1.39.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.4.0                -> v1.4.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.4.1                -> v1.4.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.40.0               -> v1.40.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.40.1               -> v1.40.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.41.0               -> v1.41.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.42.0               -> v1.42.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.43.0               -> v1.43.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.43.1               -> v1.43.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.44.0               -> v1.44.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.44.1               -> v1.44.1
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.5.0                -> v1.5.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.6.0                -> v1.6.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.7.0                -> v1.7.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.8.0                -> v1.8.0
Step #0 - "git-fetch-unshallow":  * [new tag]           v1.9.0                -> v1.9.0
Finished Step #0 - "git-fetch-unshallow"
Starting Step #1 - "make-tests"
Step #1 - "make-tests": Pulling image: us-central1-docker.pkg.dev/hpc-toolkit-dev/hpc-toolkit-repo/test-runner
Step #1 - "make-tests": Using default tag: latest
Step #1 - "make-tests": latest: Pulling from hpc-toolkit-dev/hpc-toolkit-repo/test-runner
Step #1 - "make-tests": 57f9239594e6: Pulling fs layer
Step #1 - "make-tests": 2377065f3b70: Pulling fs layer
Step #1 - "make-tests": 5ee26b7a209f: Pulling fs layer
Step #1 - "make-tests": 6e6ac2a88b4b: Pulling fs layer
Step #1 - "make-tests": 06f05ace1117: Pulling fs layer
Step #1 - "make-tests": a0b9a6800858: Pulling fs layer
Step #1 - "make-tests": 4f4fb700ef54: Pulling fs layer
Step #1 - "make-tests": f3f329baf72e: Pulling fs layer
Step #1 - "make-tests": 22d1e915df22: Pulling fs layer
Step #1 - "make-tests": 6e6ac2a88b4b: Waiting
Step #1 - "make-tests": 06f05ace1117: Waiting
Step #1 - "make-tests": a0b9a6800858: Waiting
Step #1 - "make-tests": f3f329baf72e: Waiting
Step #1 - "make-tests": 22d1e915df22: Waiting
Step #1 - "make-tests": 2377065f3b70: Verifying Checksum
Step #1 - "make-tests": 2377065f3b70: Download complete
Step #1 - "make-tests": 57f9239594e6: Verifying Checksum
Step #1 - "make-tests": 57f9239594e6: Download complete
Step #1 - "make-tests": 5ee26b7a209f: Verifying Checksum
Step #1 - "make-tests": 5ee26b7a209f: Download complete
Step #1 - "make-tests": a0b9a6800858: Verifying Checksum
Step #1 - "make-tests": a0b9a6800858: Download complete
Step #1 - "make-tests": 4f4fb700ef54: Verifying Checksum
Step #1 - "make-tests": 4f4fb700ef54: Download complete
Step #1 - "make-tests": f3f329baf72e: Verifying Checksum
Step #1 - "make-tests": f3f329baf72e: Download complete
Step #1 - "make-tests": 6e6ac2a88b4b: Verifying Checksum
Step #1 - "make-tests": 6e6ac2a88b4b: Download complete
Step #1 - "make-tests": 06f05ace1117: Verifying Checksum
Step #1 - "make-tests": 06f05ace1117: Download complete
Step #1 - "make-tests": 57f9239594e6: Pull complete
Step #1 - "make-tests": 2377065f3b70: Pull complete
Step #1 - "make-tests": 5ee26b7a209f: Pull complete
Step #1 - "make-tests": 6e6ac2a88b4b: Pull complete
Step #1 - "make-tests": 22d1e915df22: Verifying Checksum
Step #1 - "make-tests": 22d1e915df22: Download complete
Step #1 - "make-tests": 06f05ace1117: Pull complete
Step #1 - "make-tests": a0b9a6800858: Pull complete
Step #1 - "make-tests": 4f4fb700ef54: Pull complete
Step #1 - "make-tests": f3f329baf72e: Pull complete
Step #1 - "make-tests": 22d1e915df22: Pull complete
Step #1 - "make-tests": Digest: sha256:6563890dc3ebbeecf5d3fbbe8e0dc4c7ccc419d1755c51b7604d91a7bd6524e3
Step #1 - "make-tests": Status: Downloaded newer image for us-central1-docker.pkg.dev/hpc-toolkit-dev/hpc-toolkit-repo/test-runner:latest
Step #1 - "make-tests": us-central1-docker.pkg.dev/hpc-toolkit-dev/hpc-toolkit-repo/test-runner:latest
Step #1 - "make-tests": **************** vetting go code **********************
Step #1 - "make-tests": **************** running gcluster unit tests **************
Step #1 - "make-tests": go vet ./cmd/... ./pkg/...
Step #1 - "make-tests": go: downloading golang.org/x/sys v0.27.0
Step #1 - "make-tests": go: downloading gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
Step #1 - "make-tests": go: downloading github.com/spf13/afero v1.11.0
Step #1 - "make-tests": go: downloading github.com/go-git/go-git/v5 v5.12.0
Step #1 - "make-tests": go: downloading github.com/go-git/go-billy/v5 v5.6.0
Step #1 - "make-tests": go: downloading github.com/zclconf/go-cty-debug v0.0.0-20240509010212-0d6042c53940
Step #1 - "make-tests": go: downloading golang.org/x/sync v0.7.0
Step #1 - "make-tests": go: downloading github.com/kr/pretty v0.3.1
Step #1 - "make-tests": go: downloading golang.org/x/text v0.16.0
Step #1 - "make-tests": go: downloading github.com/cyphar/filepath-securejoin v0.2.5
Step #1 - "make-tests": go: downloading github.com/ProtonMail/go-crypto v1.1.0-alpha.2
Step #1 - "make-tests": go: downloading golang.org/x/net v0.27.0
Step #1 - "make-tests": go: downloading github.com/kr/text v0.2.0
Step #1 - "make-tests": go: downloading github.com/rogpeppe/go-internal v1.11.0
Step #1 - "make-tests": go: downloading golang.org/x/crypto v0.25.0
Step #1 - "make-tests": go: downloading github.com/skeema/knownhosts v1.2.2
Step #1 - "make-tests": go test -cover ./cmd/... ./pkg/... 2>&1 |  perl tools/enforce_coverage.pl
Step #1 - "make-tests": ok  	hpc-toolkit/cmd	0.091s	coverage: 41.5% of statements
Step #1 - "make-tests": 	hpc-toolkit/pkg/logging		coverage: 0.0% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/config	0.121s	coverage: 86.9% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/deploymentio	0.021s	coverage: 88.2% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/inspect	0.392s	coverage: 86.0% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/modulereader	0.216s	coverage: 86.3% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/modulewriter	0.074s	coverage: 80.6% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/shell	0.561s	coverage: 25.3% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/sourcereader	1.635s	coverage: 88.8% of statements
Step #1 - "make-tests": ok  	hpc-toolkit/pkg/validators	0.025s	coverage: 13.7% of statements
Step #1 - "make-tests": **************** building gcluster ************************
Step #1 - "make-tests": *********** running "Golden copy" tests ***********
Step #1 - "make-tests": tools/validate_configs/golden_copies/validate.sh
Step #1 - "make-tests": Testing igc_pkr
Step #1 - "make-tests": Testing igc_tf
Step #1 - "make-tests": Testing merge_flatten
Step #1 - "make-tests": Testing text_escape
Step #1 - "make-tests": Testing versioned_blueprint
Step #1 - "make-tests": *********** running basic integration tests ***********
Step #1 - "make-tests": tools/validate_configs/validate_configs.sh
Step #1 - "make-tests": Running tests in 8 processes
Step #1 - "make-tests": testing examples/image-builder.yaml in /tmp/tmp.1C4vON9Yzu
Step #1 - "make-tests": testing examples/hpc-slurm-v5-legacy.yaml in /tmp/tmp.H84EVpkvD0
Step #1 - "make-tests": testing examples/ml-gke.yaml in /tmp/tmp.uRyRNngoS0
Step #1 - "make-tests": testing examples/hpc-slurm-static.yaml in /tmp/tmp.F9TZJrhJaT
Step #1 - "make-tests": testing examples/ml-slurm-v5-legacy.yaml in /tmp/tmp.Onq7hlwzgS
Step #1 - "make-tests": testing examples/gke-a3-megagpu.yaml in /tmp/tmp.vxLdgMF5SZ
Step #1 - "make-tests": testing examples/machine-learning/a3-highgpu-8g/v5-legacy/ml-slurm-a3-1-image-v5-legacy.yaml in /tmp/tmp.hOL2ILebTC
Step #1 - "make-tests": testing examples/machine-learning/a3-highgpu-8g/v5-legacy/ml-slurm-a3-2-cluster-v5-legacy.yaml in /tmp/tmp.FavlrALe2b
Step #1 - "make-tests": testing examples/machine-learning/a3-highgpu-8g/v5-legacy/ml-slurm-a3-0-base-v5-legacy.yaml in /tmp/tmp.6tilxwl9gr
Step #1 - "make-tests": testing examples/machine-learning/a3-highgpu-8g/ml-slurm-a3-0-base.yaml in /tmp/tmp.D9U8FDaFQe
Step #1 - "make-tests": testing examples/machine-learning/a3-highgpu-8g/ml-slurm-a3-1-image.yaml in /tmp/tmp.0soRNVFMOT
Step #1 - "make-tests": testing examples/machine-learning/a3-highgpu-8g/ml-slurm-a3-2-cluster.yaml in /tmp/tmp.m9kJHJqLZC
Step #1 - "make-tests": testing examples/machine-learning/a3-ultragpu-8g/a3ultra-slurm-blueprint.yaml in /tmp/tmp.8aT8UhNC94
Step #1 - "make-tests": Error: deployment variable "zone" was not set
Step #1 - "make-tests": 28:   zone: # supply zone
Step #1 - "make-tests":       ^
Step #1 - "make-tests": Error: deployment variable "a3u_reservation_name" was not set
Step #1 - "make-tests": 30:   a3u_reservation_name: # supply reservation name
Step #1 - "make-tests":       ^
Step #1 - "make-tests": Error: deployment variable "region" was not set
Step #1 - "make-tests": 27:   region: # supply region
Step #1 - "make-tests":       ^
Step #1 - "make-tests": Error: deployment variable "a3u_cluster_size" was not set
Step #1 - "make-tests": 29:   a3u_cluster_size: # supply cluster size
Step #1 - "make-tests":       ^
Step #1 - "make-tests": 
Step #1 - "make-tests": *** ERROR: error creating deployment with gcluster for a3ultra-slurm-blueprint.yaml
Step #1 - "make-tests": *** ERROR: a test failed. Exiting with status 1.
Step #1 - "make-tests": make: *** [Makefile:160: validate_configs] Error 1
Finished Step #1 - "make-tests"
ERROR
ERROR: build step 1 "us-central1-docker.pkg.dev/hpc-toolkit-dev/hpc-toolkit-repo/test-runner" failed: step exited with non-zero status: 2

Build Log: https://console.cloud.google.com/cloud-build/builds/e8f2ecba-7527-4dc3-aaad-14504bcf8075?project=508417052821