Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back merging release v1.43.0 changes to develop #3350

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Back merging release v1.43.0 changes to develop #3350

merged 5 commits into from
Dec 5, 2024

Conversation

ighosh98
Copy link
Contributor

@ighosh98 ighosh98 commented Dec 5, 2024

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 added the release-chore To not include into release notes label Dec 5, 2024
annuay-google
annuay-google approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, back-merge from main to develop

@ighosh98 ighosh98 merged commit ca73935 into develop Dec 5, 2024
12 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annuay-google annuay-google annuay-google approved these changes

Assignees
No one assigned
Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ighosh98 @annuay-google @alyssa-sm @cdunbar13 @tpdownes