Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlurmGCP. Fix bug that prevents resourcePolicies clean up. #3266

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Nov 15, 2024

Bug introduced 3 month ago by #2892 , the clean up logic wasn't updated with new name format.

@mr0re1 mr0re1 requested a review from abbas1902 November 15, 2024 18:36
@mr0re1 mr0re1 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Nov 15, 2024
abbas1902
abbas1902 previously approved these changes Nov 15, 2024
@abbas1902 abbas1902 assigned mr0re1 and unassigned abbas1902 Nov 15, 2024
@mr0re1 mr0re1 changed the base branch from develop to release-candidate November 15, 2024 22:51
@mr0re1 mr0re1 dismissed abbas1902’s stale review November 15, 2024 22:51

The base branch was changed.

Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mr0re1 mr0re1 merged commit b061162 into GoogleCloudPlatform:release-candidate Nov 16, 2024
8 of 56 checks passed
@mr0re1 mr0re1 deleted the clean_policy branch November 16, 2024 00:12
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants