Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for kueue v0.9.0 to enable TAS #3260

Merged

Conversation

ighosh98
Copy link
Contributor

@ighosh98 ighosh98 commented Nov 14, 2024

Added support for kueue v0.9.0 which was released recently with TAS enabled for all clusters. As aligned offline, Kueue-v0.9.0 would now be the default Kueue version choice for customers.

kueue-v0.9.0 has TAS enabled in alpha phase. Have added necessary tolerations to kueue-v0.9.0 file to make the manifest compatible with cluster-toolkit.

Testing Information

Testing was done on a2-high clusters.

Ran the command:
kubectl get pods -o custom-columns="Name:.metadata.name,Host:.spec.nodeSelector.cloud\.google\.com/gce-topology-host" | sort -k2
Job Annotation:

        kueue.x-k8s.io/podset-required-topology: "cloud.google.com/gce-topology-host"

Output:
Was testing host topology compliance required job. Observe that all pods are on the same host:

tas-sample-small-required-host-gqm74-0-sksh6   2131055a3f84f1c773b6cddca39d1a24
tas-sample-small-required-host-gqm74-1-gls2s   2131055a3f84f1c773b6cddca39d1a24
tas-sample-small-required-host-gqm74-2-7vchk   2131055a3f84f1c773b6cddca39d1a24
tas-sample-small-required-host-gqm74-3-rnhqv   2131055a3f84f1c773b6cddca39d1a24
tas-sample-small-required-host-x72sr-0-5bh4v   2131055a3f84f1c773b6cddca39d1a24
tas-sample-small-required-host-x72sr-1-h7b9k   2131055a3f84f1c773b6cddca39d1a24
tas-sample-small-required-host-x72sr-2-c4prq   2131055a3f84f1c773b6cddca39d1a24
tas-sample-small-required-host-x72sr-3-gwkb9   2131055a3f84f1c773b6cddca39d1a24
Name                                           Host 

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 added the enhancement New feature or request label Nov 14, 2024
@ighosh98 ighosh98 self-assigned this Nov 15, 2024
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98 ighosh98 requested a review from ankitkinra November 15, 2024 15:05
@ighosh98 ighosh98 changed the title upgrade kueue default version to v0.9.0 to support TAS add support for kueue v0.9.0 to enable TAS Nov 15, 2024
@ighosh98 ighosh98 merged commit 1d1cfbe into GoogleCloudPlatform:experimental Nov 15, 2024
5 of 54 checks passed
ighosh98 added a commit to ighosh98/cluster-toolkit that referenced this pull request Nov 18, 2024
…l-kueue

add support for kueue v0.9.0 to enable TAS
@ighosh98 ighosh98 deleted the experimental-kueue branch November 27, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants