Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where try was hiding extraction of gpu driver version #3257

Merged

Conversation

ankitkinra
Copy link
Contributor

Fix a bug where try was hiding extraction of gpu driver version

try was hiding the fact that we did not use the iterate syntax correctly.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ankitkinra ankitkinra added the release-bugfix Added to release notes under the "Bug fixes" heading. label Nov 14, 2024
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitkinra ankitkinra enabled auto-merge November 14, 2024 10:47
@ankitkinra ankitkinra merged commit b5804ae into GoogleCloudPlatform:develop Nov 14, 2024
10 of 57 checks passed
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants