Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Access to GCE Public IPs for the GKE Integration Test Clusters #3249

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

arajmane-g
Copy link
Contributor

@arajmane-g arajmane-g commented Nov 12, 2024

About the Change

Enable Access to GCE Public IPs for the GKE Integration Test Clusters so that the Toolkit Clean up tool (tools/cleanup-build.py) should be able clean up resources.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@arajmane-g arajmane-g added release-chore To not include into release notes test-enhancement Tests enhancement or coverage improvement and removed release-chore To not include into release notes test-enhancement Tests enhancement or coverage improvement labels Nov 12, 2024
@arajmane-g
Copy link
Contributor Author

Triggered a few tests. They are failing. Looking into the failures

Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please deploy a blueprint directly (not through integration tests ) and confirm that it also passes ?

@arajmane-g
Copy link
Contributor Author

Can you also please deploy a blueprint directly (not through integration tests ) and confirm that it also passes ?

Yes, I have done that.

@arajmane-g arajmane-g merged commit e12c9ec into GoogleCloudPlatform:develop Nov 19, 2024
16 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes test-enhancement Tests enhancement or coverage improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants