-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated aip version and removed the special kernel #425
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3e0e457
to
17f44ba
Compare
@@ -164,7 +164,7 @@ | |||
"vectors = []\n", | |||
"\n", | |||
"for i in range(0, len(metadata), MAX_BATCH_SIZE):\n", | |||
" batch = metadata.abstract[i : i + MAX_BATCH_SIZE]\n", | |||
" batch = metadata.abstract[i : i + MAX_BATCH_SIZE].to_list()\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenoitDherin Added this line due to the additional type check introduced in 1.36.1. (Now it doesn't take pd.Series.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
google-cloud-aiplatform
to support new capabilities by default including Gemini.gemini_kernel
as it became unnecessary.