Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated aip version and removed the special kernel #425

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

takumiohym
Copy link
Collaborator

  • Updated google-cloud-aiplatform to support new capabilities by default including Gemini.
  • Removed the gemini_kernel as it became unnecessary.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@takumiohym takumiohym marked this pull request as draft March 13, 2024 14:16
Copy link
Collaborator

@BenoitDherin BenoitDherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takumiohym takumiohym force-pushed the update_aiplatform_lib branch from 3e0e457 to 17f44ba Compare March 19, 2024 14:34
@@ -164,7 +164,7 @@
"vectors = []\n",
"\n",
"for i in range(0, len(metadata), MAX_BATCH_SIZE):\n",
" batch = metadata.abstract[i : i + MAX_BATCH_SIZE]\n",
" batch = metadata.abstract[i : i + MAX_BATCH_SIZE].to_list()\n",
Copy link
Collaborator Author

@takumiohym takumiohym Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenoitDherin Added this line due to the additional type check introduced in 1.36.1. (Now it doesn't take pd.Series.)

googleapis/python-aiplatform@5294972

Copy link
Collaborator

@sanjanalreddy sanjanalreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takumiohym takumiohym marked this pull request as ready for review March 20, 2024 09:34
@takumiohym takumiohym merged commit e5ca792 into master Mar 20, 2024
5 checks passed
@takumiohym takumiohym deleted the update_aiplatform_lib branch March 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants