Support spark.sql.datetime.java8API.enabled #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tom-s-powell , thanks for the PR! It seems that the relevant methods are in |
|
Also, it seem to be available only in Spark 3.5, so we may need our own implementation instead of the Spark one to support older Spark versions. |
|
Ah yes looks like they moved in recent version. I've added the implementation directly rather than relying on the Spark one. |
|
/gcbrun |
davidrabinowitz
approved these changes
Oct 9, 2024
davidrabinowitz
approved these changes
Oct 11, 2024
|
/gcbrun |
|
@davidrabinowitz are we okay to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
spark.sql.datetime.java8API.enabledistrue, Spark dates and timestamps will be returned asjava.time.LocalDate/java.time.Instantrather thanjava.sql.Date/java.sql.Timestamp.https://issues.apache.org/jira/browse/SPARK-38437 addressed this in https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala so perhaps this code path could leverage that?
Currently if this config is enabled you hit
java.lang.ClassCastException.