-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gpu] Exercise new template-generated GPU driver installer #1290
Draft
cjac
wants to merge
125
commits into
GoogleCloudDataproc:master
Choose a base branch
from
LLC-Technologies-Collier:gpu-template-20250107
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[gpu] Exercise new template-generated GPU driver installer #1290
cjac
wants to merge
125
commits into
GoogleCloudDataproc:master
from
LLC-Technologies-Collier:gpu-template-20250107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/gcbrun |
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 8, 2025 02:42
e70ed0c
to
85e3ec7
Compare
/gcbrun |
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 8, 2025 03:46
85e3ec7
to
b412084
Compare
/gcbrun |
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 8, 2025 04:14
b412084
to
c9a22d6
Compare
/gcbrun |
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 8, 2025 04:47
c9a22d6
to
ca0945b
Compare
/gcbrun |
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 8, 2025 05:41
ca0945b
to
7167512
Compare
/gcbrun |
1 similar comment
/gcbrun |
…the root template ; do not hold nvidia packages in the prepare function
* increased minimum memory threshold for ram disk * moved apt_add_repo and friends to common/install_functions templates/dask/util_functions: * validating conda tarball before caching to gcs templates/generate-action.pl: * improved usage documentation a little templates/gpu/install_functions * using /opt/conda/miniconda3/bin/python3 instead of /usr/bin/ for venv pre-install
* increase wait time for scheduler to come online * reduce noise from tar -t templates/gpu/yarn_functions, templates/gpu/install_functions: * protect many functions from running without attached accelerator templates/gpu/install_gpu_driver.sh.in * set +e in exit handler templates/gpu/spark_functions: * re-factor new function into this template templates/spark-rapids/spark-rapids.sh.in * removed redundant call to configure_gpu_script * set +e in exit handler
…ing the readonly operations
cjac
force-pushed
the
gpu-template-20250107
branch
2 times, most recently
from
January 9, 2025 20:27
b7e53d1
to
1a6fd39
Compare
/gcbrun |
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 9, 2025 21:35
21818bd
to
81bd2f4
Compare
* include version in action generator
cjac
force-pushed
the
gpu-template-20250107
branch
2 times, most recently
from
January 9, 2025 22:37
8b94c08
to
997a61c
Compare
/gcbrun |
cjac
changed the title
[gpu] this PR for testing purposes only
[gpu] Exercise new template-generated GPU driver installer
Jan 10, 2025
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 10, 2025 04:25
997a61c
to
6bb948b
Compare
/gcbrun |
gpu/test_gpu.py: * using tests from GoogleCloudDataproc#1275 gpu/verify_pyspark.py: * new test file ; will probably be moved to mlvm templates/gpu/install_gpu_driver.sh.in: * this action template includes only the code unique to this action
cjac
force-pushed
the
gpu-template-20250107
branch
from
January 10, 2025 04:32
6bb948b
to
453e6e6
Compare
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for exercising the generated test against unmodified master test suite