Skip to content

Commit

Permalink
Local build generate non consumable pom files (#115)
Browse files Browse the repository at this point in the history
Current main branch build generate having POM containing ${revision} has
version.

![Screenshot 2024-04-30 at 5 26
57 PM](https://github.com/GoogleCloudDataproc/flink-bigquery-connector/assets/3120359/95b75c54-8814-489c-a12c-45875b68e287)


This is neatly explained in the official maven documentation:
https://maven.apache.org/maven-ci-friendly.html#install-deploy I updated
main pom with official suggestion. Currently it works on my machine.

---------

Co-authored-by: Talat Uyarer <[email protected]>
  • Loading branch information
talatuyarer and talatuyarer authored May 1, 2024
1 parent 1d5d35f commit e5ba181
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
target/
.flattened-pom.xml
pom.xml.tag
pom.xml.releaseBackup
pom.xml.versionsBackup
Expand All @@ -18,4 +19,4 @@ tools/japicmp-output
java.header
.java-version
nb-*
**nbproject
**nbproject
25 changes: 25 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,31 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
<version>1.5.0</version>
<configuration>
<updatePomFile>true</updatePomFile>
<flattenMode>resolveCiFriendliesOnly</flattenMode>
</configuration>
<executions>
<execution>
<id>flatten</id>
<phase>verify</phase>
<goals>
<goal>flatten</goal>
</goals>
</execution>
<execution>
<id>flatten.clean</id>
<phase>clean</phase>
<goals>
<goal>clean</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.commonjava.maven.plugins</groupId>
<artifactId>directory-maven-plugin</artifactId>
Expand Down

0 comments on commit e5ba181

Please sign in to comment.