Not allow GET requests for URL handlers that change state on the server side #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojarjur
requested changes
Sep 23, 2024
| @@ -183,6 +183,7 @@ async def mock_config(config_field): | |||
| "system": mock_system, | |||
| "type": mock_type, | |||
| }, | |||
| method="POST", | |||
There was a problem hiding this comment.
You need to add allow_nonstandard_methods=True, here in order to get the test to pass.
| @@ -129,6 +129,7 @@ async def mock_list_dag_run_task(*args, **kwargs): | |||
| "dag_id": mock_dag_id, | |||
| "dag_run_id": mock_dag_run_id, | |||
| }, | |||
| method="POST", | |||
There was a problem hiding this comment.
You need to add allow_nonstandard_methods=True, here, and in all the similar lines below, in order to get the test to pass.
ojarjur
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigQuerySearch handler and downloadOutput handler changed from GET to POST