gsutil commands to async #165
Merged
+108
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-changes Bug fix and search functionality code commented
…om/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-dataset-explorer-changes
…er-changes Schema empty error message added
…om/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-dataset-explorer-changes
This reverts commit 799f604.
This reverts commit 0844b26.
Toast removed for empty cluster
…er-changes Bug tracker fixes - ID 226, 227
…om/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-dataset-explorer-changes
…er-changes Big Query search functionality changes
…om/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-dataset-explorer-changes
…er-changes Dataset explorer backend code formatting
…om/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-dataset-explorer-changes
…er-changes Bug tracker fixes - 228
…upyter-plugin-fork into sprint19-dataset-explorer-fixes
…onal-properties Runtime - spark properties feedback changes and internal fixes
…ub.com/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint20-runtime-additional-properties
…onal-properties scheduler test file removed
…upyter-plugin-fork into sprint21-gsutil-async-changes
…upyter-plugin-fork into sprint21-gsutil-async-changes
…hanges gsutil commands to async
ojarjur
reviewed
Jul 19, 2024
src/batches/batchDetails.tsx
Outdated
| @@ -13,6 +13,7 @@ | |||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| * | |||
There was a problem hiding this comment.
Revert this change.
We will not alter the copyright header.
ojarjur
reviewed
Jul 19, 2024
| import tempfile | ||
|
|
||
|
|
||
| async def async_command_executor(cmd): |
There was a problem hiding this comment.
This is too generic, reducing the amount of value it adds.
Instead, let's make this method specific to gsutil, similarly to the async_run_gcloud_subcommand method
…hanges gsutil - review comments changes
ojarjur
reviewed
Jul 24, 2024
Comment on lines
102
to
105
| except subprocess.CalledProcessError as error: | ||
| self.log.exception("Error deleting dag") | ||
| raise Exception( | ||
| f"Error getting airflow uri: {response.reason} {await response.text()}" |
There was a problem hiding this comment.
This exception constructor is clearly wrong; it's reporting the response text when the error came from running a gsutil command.
Moreover, however, this entire nested try-except block is redundant. The inner try should be removed and just rely on the outer except block to report the error.
…hanges gsutil review comment fix
ojarjur
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.