Bug tracker and Buganizer fixes #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-change passing runtime version to serverless dag
…upyter-plugin-fork into sprint19-bigquery-launcher-changes
…om/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-dataset-explorer-changes
…m/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-dataset-explorer-changes
…upyter-plugin-fork into sprint20-client-bug-tracker-fixes
…cker-fixes Settings page FE changes and Dag store copy BE changes
…upyter-plugin-fork into sprint20-client-bug-tracker-fixes
…m/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint20-client-bug-tracker-fixes
ptwng
approved these changes
May 29, 2024
…cker-fixes Sprint20 client bug tracker fixes
ojarjur
reviewed
May 29, 2024
| import json | ||
| from dataproc_jupyter_plugin import credentials |
There was a problem hiding this comment.
Wrong import order (see https://peps.python.org/pep-0008/#imports).
The imports should go as follows:
- Standard library imports
- Third-party imports
- Same package imports
... so the credentials import (from this same package) should be after the tornado import (from a third-party package).
ojarjur
reviewed
May 29, 2024
| import pendulum | ||
| import requests | ||
| from datetime import datetime, timedelta |
There was a problem hiding this comment.
Wrong import order here.
It should be:
from datetime import datetime, timedelta
import os
import shutil
import subprocess
import uuid
from google.cloud.jupyter_config.config import gcp_account
from jinja2 import Environment, PackageLoader, select_autoescape
import pendulum
import requests
from dataproc_jupyter_plugin import urls
...
ojarjur
reviewed
May 29, 2024
| @@ -56,6 +62,7 @@ async def test_list_datasets(monkeypatch, jp_fetch): | |||
| ) | |||
| assert response.code == 200 | |||
| payload = json.loads(response.body) | |||
| print("payload ---------", payload) | |||
There was a problem hiding this comment.
Remove this debugging code.
ojarjur
reviewed
May 29, 2024
Comment on lines
34
to
41
| # def mock_get(api_endpoint, headers=None): | ||
| # response = Mock() | ||
| # response.status_code = 200 | ||
| # response.json.return_value = { | ||
| # "api_endpoint": api_endpoint, | ||
| # "headers": headers, | ||
| # } | ||
| # return response |
There was a problem hiding this comment.
Delete this commented-out code
…upyter-plugin-fork into sprint20-client-bug-tracker-fixes
…m/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint20-client-bug-tracker-fixes
…cker-fixes Backend review comments fixes
…cker-fixes removing unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.