Bug fixes #142
Merged
Bug fixes #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Shubha-accenture
commented
Apr 26, 2024
•
Shubha-accenture
commented
- Implemented server side pagination
- Pagination changes for fetching first and last page
- Vertical spacing for Dataset explorer (Schema and Preview)
- Addressed review comments on dataset explorer
…-review-fixes Sprint19 scheduler code review fixes
…-review-fixes Code review changes
…upyter-plugin-fork into sprint19-bigquery-launcher-changes
…upyter-plugin-fork into sprint19-scheduler-enhancement-changes
…upyter-plugin-fork into sprint19-scheduler-enhancement-changes
…ncement-changes Sprint19 scheduler enhancement changes
…upyter-plugin-fork into sprint19-bigquery-launcher-changes
This reverts commit 24ff2e7.
…upyter-plugin-fork into sprint19-scheduler-enhancement-changes
1. Logo in dark mode color change 2. Loader added for cluster and serverless dropdown
…upyter-plugin-fork into sprint19-scheduler-enhancement-changes
…upyter-plugin-fork into sprint19-bigquery-launcher-changes
…ub.com/Shubha-accenture/dataproc-jupyter-plugin-fork into sprint19-scheduler-enhancement-changes
…ncement-changes Scheduler internal bug fixes
…upyter-plugin-fork into sprint19-bigquery-launcher-changes
1. Tooltip for cards changed 2. Local kernel - Create scheduler loader fix
ojarjur
reviewed
May 6, 2024
There was a problem hiding this comment.
Please rename this to dataproc_juptyer_plugin/credentials.py.
There's no reason to have anything in the codebase named utils.
There was a problem hiding this comment.
- credentials.py is renamed to gcloudOperations.py
- utils folder is renamed to commons as it contains all the common code.
…er-fixes execution history height changes
…er-fixes Backend file, folder name changes
…upyter-plugin-fork into sprint19-dataset-explorer-fixes
…er-fixes Dpms Service refactor and Big Query changes
ptwng
approved these changes
May 9, 2024
src/bigQuery/previewDataInfo.tsx
Outdated
|
|
||
| const previewHeight = window.innerHeight - 180; |
There was a problem hiding this comment.
this wouldn't work if the user resizes the browser after js was loaded
|
Just the one thing around statically grabbing the window width |
ptwng
suggested changes
May 9, 2024
ojarjur
reviewed
May 9, 2024
…er-fixes Height resize handled on window height change
ptwng
approved these changes
May 17, 2024
…cker-fixes Client bug tracker & Buganizer fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.