Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Async Tasks data cache issue #997

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Fix Async Tasks data cache issue #997

merged 2 commits into from
Dec 19, 2024

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented Dec 18, 2024

Fix the timing bug mentioned in #992 (review). There is a weird Async Tasks cache issue, possibly due to Saves the last completion value or error of the task function. It reassigns an old value of this.TasktaskTracker after New Task is defined but before the callback executes.

As a result, the pending UI on the overview page loads correctly when users navigate.

@KyleJu KyleJu requested a review from jcscottiii December 18, 2024 22:46
@KyleJu KyleJu marked this pull request as ready for review December 18, 2024 22:46
Copy link
Collaborator

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@jcscottiii
Copy link
Collaborator

Thanks for looking into this!

@KyleJu KyleJu enabled auto-merge December 19, 2024 01:28
@KyleJu KyleJu added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 214db6d Dec 19, 2024
6 checks passed
@KyleJu KyleJu deleted the fix-fetch-bug branch December 19, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants