Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load only one year of data on /stats #886

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Load only one year of data on /stats #886

merged 4 commits into from
Nov 11, 2024

Conversation

past
Copy link
Collaborator

@past past commented Nov 9, 2024

This is part of the solution for #789.

Also, this change makes color assignment consistent with the feature details page, and fixes a typo in the breadcrumbs.

@past
Copy link
Collaborator Author

past commented Nov 9, 2024

The playwright failures are expected due to the stats graph change and the typo fix in the feature details page. However I'm having a hard time updating them because make playwright-update-snapshots is timing out on many tests.

@jcscottiii
Copy link
Collaborator

If this is still timing out on the cloud top, there are a few things we could do:

Option 1: Run with one worker

Run CI=true make playwright-update-snapshots. This causes the tests to run with one worker like we do in github. On the cloud top, the tests run with a lot of workers by default due to the number of cores. Which might be causing things to be unstable

Option 2: Manually setup the server and run the specific test in vscode

In terminal 1, run: make start-local

In terminal 2, run:

make dev_fake_data 
make dev_fake_users
make port-forward-manual

Delete the screenshots that you want re-generated

Open vscode and go to the test section on the side bar (Or View->Testing) and run the tests.

image

Let me know which option you end up using and I can adjust the docs.

@past
Copy link
Collaborator Author

past commented Nov 11, 2024

Thanks for the detailed instructions. I went with option 1 which worked quickly and flawlessly, but I think it's useful to document both approaches for other cases.

@past past requested a review from jcscottiii November 11, 2024 18:11
@jcscottiii
Copy link
Collaborator

Thanks for the detailed instructions. I went with option 1 which worked quickly and flawlessly, but I think it's useful to document both approaches for other cases.

Will do! Added #899 so we won't lose that idea.

@past past force-pushed the past/chart-one-year branch from ace0118 to ab4f19d Compare November 11, 2024 18:57
@past past added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@jcscottiii jcscottiii added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 0bcfcdd Nov 11, 2024
6 checks passed
@jcscottiii jcscottiii deleted the past/chart-one-year branch November 11, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants