move handles from appuser to workspace (with fallback) #585

nikochiko · 2025-01-08T15:00:30Z

Q/A checklist

If you add new dependencies, did you update the lock file?

poetry lock --no-update

Run tests

ulimit -n unlimited && ./scripts/run-tests.sh

Do a self code review of the changes - Read the diff at least twice.
Carefully think about the stuff that might break because of this change - this sounds obvious but it's easy to forget to do "Go to references" on each function you're changing and see if it's used in a way you didn't expect.
The relevant pages still run when you press submit
The API for those pages still work (API tab)
The public API interface doesn't change if you didn't want it to (check API tab > docs page)
Do your UI changes (if applicable) look acceptable on mobile?
Ensure you have not regressed the import time unless you have a good reason to do so.
You can visualize this using tuna:

python3 -X importtime -c 'import server' 2> out.log && tuna out.log

To measure import time for a specific library:

$ time python -c 'import pandas'

________________________________________________________
Executed in    1.15 secs    fish           external
   usr time    2.22 secs   86.00 micros    2.22 secs
   sys time    0.72 secs  613.00 micros    0.72 secs

To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:

def my_function():
    import pandas as pd
    ...

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

nikochiko · 2025-01-08T15:01:10Z

app_users/models.py

+        workspace, _ = self.get_or_create_personal_workspace()
+
+        if handle := Handle.create_default_for_user(user=self):
+            workspace.handle = handle
+            workspace.save()


for new users, handle should be on the workspace

nikochiko · 2025-01-08T15:01:59Z

app_users/models.py

+    def get_handle(self) -> Handle | None:
+        if self.handle:
+            return self.handle
+        workspace, _ = self.get_or_create_personal_workspace()
+        return workspace.handle


cache get_or_create_personal_workspace()?

nikochiko · 2025-01-08T15:03:16Z

daras_ai_v2/base.py

-        if show_as_link and workspace.is_personal and workspace.created_by.handle:
-            link = workspace.created_by.handle.get_app_url()
+        if show_as_link and workspace.is_personal:
+            handle = workspace.handle or workspace.created_by.handle


not using workspace.created_by.get_handle() because personal workspace already

nikochiko · 2025-01-08T15:04:25Z

daras_ai_v2/profiles.py

+    handle = user.get_handle()
+    assert handle


assert (handle := user.get_handle()) is also valid python

nikochiko · 2025-01-08T15:08:51Z

app_users/migrations/0024_alter_appuser_handle.py

+        migrations.AlterField(
+            model_name='appuser',
+            name='handle',
+            field=models.OneToOneField(blank=True, default=None, help_text='[deprecated] use workspace.handle instead', null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='user', to='handles.handle'),


adds help_text='[deprecated] ... here

nikochiko · 2025-01-08T15:10:33Z

handles/models.py

+        if (
+            self.has_workspace
+            and self.has_user
+            and self.workspace.created_by_id == self.user.id
+        ):
+            # TODO: remove this once all handles are migrated
+            return


to handle an in-between state where the same handle can be attached to a personal workspace & its user. won't be needed after cleanup_handles() is run in the script

greptile-apps

PR Summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

_{14 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings | Greptile}

devxpy · 2025-01-10T08:26:36Z

missed?

gooey-server/workspaces/views.py

Line 468 in bd355fa

with gui.link(to=m.user.handle.get_app_url()):

devxpy · 2025-01-10T08:27:08Z

routers/root.py

-            user_profile_page(request, handle.user)
-        return dict(meta=get_meta_tags_for_profile(handle.user))
+            user_profile_page(request, user)
+        return dict(meta=get_meta_tags_for_profile(user))


pass handle into user_profile_page / get_meta_tags_for_profile directly instead of doing a 2x lookup

devxpy · 2025-01-10T08:29:28Z

routers/account.py

@@ -329,11 +329,11 @@ def _render_run(pr: PublishedRun):
        return

    if workspace.is_personal:
-        if request.user.handle:
+        if handle := request.user.get_handle():


this should be workspace.handle

greptile-apps

PR Summary

(updates since last review)

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

_{3 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps

PR Summary

(updates since last review)

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings | Greptile}

nikochiko · 2025-01-10T10:02:05Z

thanks, fixed.

nikochiko added 2 commits January 8, 2025 20:29

move handles from appuser to workspace (with fallback)

bd355fa

fix: routing logic for handle page

b989d96

nikochiko commented Jan 8, 2025

View reviewed changes

add handle<>workspace connection to admin pages

d876cca

nikochiko marked this pull request as ready for review January 8, 2025 15:22

nikochiko requested a review from devxpy January 8, 2025 15:22

greptile-apps bot reviewed Jan 8, 2025

View reviewed changes

nikochiko assigned devxpy Jan 8, 2025

devxpy reviewed Jan 10, 2025

View reviewed changes

nikochiko added 2 commits January 10, 2025 15:17

fix: use correct handle in views.py

f046ce6

pass down handle for /{handle} route

a8d1662

greptile-apps bot reviewed Jan 10, 2025

View reviewed changes

use workspace.handle or request.user.handle vs user.get_handle()

760a5ba

greptile-apps bot reviewed Jan 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move handles from appuser to workspace (with fallback) #585

move handles from appuser to workspace (with fallback) #585

nikochiko commented Jan 8, 2025 •

edited

Loading

nikochiko Jan 8, 2025

nikochiko Jan 8, 2025

nikochiko Jan 8, 2025

nikochiko Jan 8, 2025

nikochiko Jan 8, 2025

nikochiko Jan 8, 2025

greptile-apps bot left a comment

devxpy commented Jan 10, 2025

devxpy Jan 10, 2025 •

edited

Loading

nikochiko Jan 10, 2025

devxpy Jan 10, 2025

nikochiko Jan 10, 2025

greptile-apps bot left a comment

greptile-apps bot left a comment

nikochiko commented Jan 10, 2025

move handles from appuser to workspace (with fallback) #585

Are you sure you want to change the base?

move handles from appuser to workspace (with fallback) #585

Conversation

nikochiko commented Jan 8, 2025 • edited Loading

Q/A checklist

Legal Boilerplate

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

devxpy commented Jan 10, 2025

devxpy Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

nikochiko commented Jan 10, 2025

nikochiko commented Jan 8, 2025 •

edited

Loading

devxpy Jan 10, 2025 •

edited

Loading