Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: truncate addresses, add link to explorer from feedmodal #4183

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Jan 9, 2024

Description

Adding addresses to feed-items and truncating for ui purposes.

  • - add addresses in the feed items
  • - update ui for txdetails (feed modal)
  • - add hyperlink to address page from modal

About # (link your issue here)
#4167

Screens

(hid my personal details in the to field but since this ui is not changed not so relevant to show)
image

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:33am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
gooddollar-delta ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 0:33am
goodid ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 0:33am

@L03TJ3 L03TJ3 marked this pull request as ready for review January 10, 2024 09:32
Copy link
Collaborator

@johnsmith-gooddollar johnsmith-gooddollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create helper for getting explorer url and you're ready to go

@L03TJ3 L03TJ3 merged commit dd4f515 into master Jan 10, 2024
9 of 15 checks passed
@L03TJ3 L03TJ3 deleted the 4167-truncate-addresses branch January 10, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants