Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4157 notification permission #4182

Merged
merged 5 commits into from
Jan 8, 2024
Merged

4157 notification permission #4182

merged 5 commits into from
Jan 8, 2024

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Dec 29, 2023

Description

It was not possible to enable notifications on android 13>. This adds the notification permission to the app settings

  • - add notification permission to android manifest

side-bug fix:

  • - breaking dialog because of posthog.initAsync called twice

About # (link your issue here)
#4157

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 5:18pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
gooddollar-delta ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 5:18pm
goodid ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 5:18pm

@L03TJ3 L03TJ3 merged commit 1d2e003 into master Jan 8, 2024
10 of 15 checks passed
@L03TJ3 L03TJ3 deleted the 4157-notification-permission branch January 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants