야간잔류 수정 기능 구현 #39
Merged
야간잔류 수정 기능 구현 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
Test Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#38
📝 작업 내용
📷 스크린샷 (선택)
위처럼 신청서를 신청하고,
신청서를 수정할 수 있습니다.
💬 리뷰 요구사항 (선택)
participant_count 변수가 신청자 포함이랑 신청자 제외를 나타내는데 모두 사용되어서 헷갈릴 수 있을 것 같습니다.
별도의 계산 없이 하나로 통일하거나, application_co_participants 테이블에 별도 컬럼으로 만들어야 할 것 같습니다.
코드 리팩토링 하겠습니다.☺️