마이 페이지 및 프로필 정보 수정 구현 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- loginId로 회원 조회하는 findByLoginId 메서드 구현
- 기존에는 memberID가 나오는 문제 해결
- getId() 가 아닌 getLoginId()로 수정
- 학번은 수정 불가 - 이름, 전화번호, 이메일 변경 가능
Closed
2 tasks
Test Coverage Report
|
holyPigeon
reviewed
Nov 22, 2024
Comment on lines
+35
to
+36
| member.updateProfile(updateRequest.getName(), updateRequest.getPhoneNumber(), updateRequest.getEmail()); | ||
| memberRepository.save(member); |
There was a problem hiding this comment.
setter 없이 처리한 부분 죠습니다...!
Comment on lines
+7
to
+15
| @Getter | ||
| @ToString | ||
| @AllArgsConstructor | ||
| public static class MyPageDTO { | ||
| private String loginId; | ||
| private String name; | ||
| private String phoneNumber; | ||
| private String email; | ||
| } |
There was a problem hiding this comment.
MyPageResponse에 필드를 바로 작성하지 않고 한 번 더 MyPageDTO로 감싸신 이유가 궁금합니다!
There was a problem hiding this comment.
재사용성이랑 보안? 관련되서 분리를 시켜서 진행하면 좋다고 해서 따라해봤습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#23
📝 작업 내용