Fix warnings when building with GCC

[gnusenpai]

Fixing the warnings is necessary for a successful build when the kernel is built with the CONFIG_WERROR option. This option is default in at least the upstream kernel config.

This PR is marked as a draft because:

1. It needs testing with clang.
2. I'm not sure how the nested #ifdef in driver/dbg.h should be formatted.
3. Removing the static keyword from the fixedpt functions creates warnings in the rust CLI build. While it technically still works, I'm not sure how to fix these. Maybe a different approach should be taken.
   Changing extern to static in the sensitivity function is an alternative fix, but it causes the CLI build to fail until changed back. Building the module with static, reverting it to extern, and then building the CLI works, if that's useful information.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
maccel	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 0:37am

[MCPO-Spartan-117]

1. It needs testing with clang.

No errors on clang.

2. I'm not sure how the nested #ifdef in driver/dbg.h should be formatted.

Should be more modularized but the \s in the functions make that complicated so i don't know how to go about that.

3. Removing the static keyword from the fixedpt functions creates warnings in the rust CLI build. While it technically still works, I'm not sure how to fix these. Maybe a different approach should be taken.
   Changing extern to static in the sensitivity function is an alternative fix, but it causes the CLI build to fail until changed back. Building the module with static, reverting it to extern, and then building the CLI works, if that's useful information.

@Gnarus-G
Are there any functions that actually need to be static? like need their own version of these functions/results and can't be overwritten later?

   Compiling maccel-cli v0.2.1 (/tmp/git/maccel/cli)
warning: maccel-cli@0.2.1: Compiler version doesn't include clang or GCC: "cc" "--version"
warning: maccel-cli@0.2.1: In file included from src/../../driver/accel.h:5,
warning: maccel-cli@0.2.1:                  from src/libmaccel.c:1:
warning: maccel-cli@0.2.1: src/../../driver/fixedptc.h:216:3: warning: ‘fixedpt_str’ is static but used in inline function ‘fixedpt_cstr’ which is not static
warning: maccel-cli@0.2.1:   216 |   fixedpt_str(A, str, max_dec);
warning: maccel-cli@0.2.1:       |   ^~~~~~~~~~~
warning: maccel-cli@0.2.1: src/../../driver/fixedptc.h:214:15: warning: ‘str’ is static but declared in inline function ‘fixedpt_cstr’ which is not static
warning: maccel-cli@0.2.1:   214 |   static char str[25];
warning: maccel-cli@0.2.1:       |               ^~~

[Gnarus-G]

If you mean just the functions in the fixedpt header file, then no I can't think of a reason they "need" to be.

[gnusenpai]

I figured out a different way to address point number 3 by making a separate wrapper function for the rust side; see the new commit: c045d82. This way fixes the warnings on both the C and rust sides. I'd like feedback on this cause it might be jank.

Should be more modularized but the \s in the functions make that complicated so i don't know how to go about that.

@MCPO-Spartan-117
I tried, but yeah, putting an #ifdef within a #define is either just not possible or really messy. The rest of the file does similar duplication, so it's not really out of place.

[gnusenpai]

I'm just gonna open this up, the code styling is up to @Gnarus-G.