Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.1 End Backport #204

Open
wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from

Conversation

VoidLeech
Copy link

Backports End support to 1.20.1

The manner is simple: Revert the revert of #164

Bear with me. #165 was actually caused by Cristel-Lib mixing into TerraBlenderConfig and not finding their injection target, and was something they had fixed in post-1.20.1 versions: Cristelknight999/Cristel-Lib@667f5b6, but never got the chance to with this version of the mod because of the quick revert.

Ignoring that, the version from that PR (and thus this one) also crashed on the world loading when used with Aeroblender, which they also fixed post-1.20.1: RazorDevs@893af50.

So there's fundamentally nothing wrong with the initial PR. But, in the spirit of compatibility, I have opened PR's with both these mods to backport their fixes too, using the fortunately released 3.0.1.5 to compile against, and so perhaps you could coordinate a release.
I had looked into rewriting the backport s.t. their injections points were still valid, but that seemed both unwise and messy.

I've tested that this PR does not crash the game (when used with the above fixes applied), on both Forge and Fabric, with decently sized modpacks containing multiple big biome mods, just flying around, verifying that biomes were still generating.

I had to pin the VanillaGradle version and just picked the latest one available at the last 1.20.1 release. For some reason, the one it currently picks by default couldn't resolve any of the Common dependencies.

none of the common dependencies were being located, fsr
@Adubbz
Copy link
Member

Adubbz commented Feb 12, 2025

I'm very happy to merge this - I'll just await the PRs in those two mods being merged first though. Give me a reminder if that happens and I don't notice and I'll merge immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants