Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Gleam 1.7.0 #39

Merged
merged 319 commits into from
Jan 20, 2025
Merged

Update to Gleam 1.7.0 #39

merged 319 commits into from
Jan 20, 2025

Conversation

PgBiel
Copy link
Member

@PgBiel PgBiel commented Jan 20, 2025 •
edited
Loading

Nix changes:

  • Updated 'use' code in expression.rs
  • Added support for let ... assert as
  • Updated record update generation: for now, it will remain the exact same (MyType(..old, new: 5) generates old // { new = 5; }), although upstream proposes a new way to update records using the type constructor, with let old' = old; in MyType old'.a old'.b 5, which was worked around for now.
  • Patched @target parsing to also consider nix target
  • Updated tests with new error message wrapping using upstream's manual text wrapping implementation
  • Ported some new bitarray language tests to nix

Devops changes:

  • New workflows for checking binary architecture, patched to check the Glistix binary

Other notable changes:

Todo:

  • Test new project
  • Test LSP
  • Compare diffs / range-diff

PgBiel and others added 30 commits January 19, 2025 21:08
@PgBiel
detect clashing gleam and javascript modules
1a155a5
@PgBiel
undo erlang-gleam conflict check
a308a33 
Ideally, `src/abc.gleam` and `src/abc.erl` would cause an error. However, this can actually occur legitimately when downloading a Hex package with precompiled `.erl` source files, which would trigger false positives. Wonder what would be the best way to detect this situation, but doesn't seem trivial to solve.
@PgBiel
separate .gleam codepath
9a027ae
@PgBiel
add subdir_ffi integration tests
3d4110a
@PgBiel
add subdir_ffi test to ci
30e8a9e
@PgBiel
use EcoString, add subdir Erlang file tests
0da1e24
@PgBiel
more robust subdir_ffi tests
0d9098e 
- Test header file in separate subdir
- Test parent folder ffi in Erlang
@PgBiel
use walkdir for native file search
6f9d4b6 
- Prevent problems with infinite symlink loops
@PgBiel
add module and native file clash error
5e306fa
@PgBiel
add error for duplicate native erlang module
c64126d
@PgBiel
update changelog with ffi subdir info
6fca8b2 
add mjs bug fix to changelog

update changelog to include erl ffi files

update changelog with js ffi change
@PgBiel
final nested ffi improvements
a05b10d
@PgBiel
custom dirwalker
d916cfa
@PgBiel
fix test project compiler
166462e
@PgBiel
dir walker: don't canonicalize returned paths
feda0f4
@PgBiel
replace reader methods by dirwalker
21348d6
@PgBiel
add dir walking test
8f984c0
@PgBiel
fix phony in subdir_ffi test
6b46208
@PgBiel
add trace back to gleam_source_files
6663e5a
@PgBiel
improve dir walker comments
557e9c9
@PgBiel
use imfs subpaths for initial files in tests
4b895d6 
We were previously including all paths in the filesystem, which
included, in particular, the root. Therefore, the "initial files"
included the root directory, causing everything to be deleted, not only
the initial files.
@PgBiel
add note about root path
730ecac
@PgBiel
ensure imfs has root
fe35e33
@PgBiel
cannot delete root from imfs
afb2cc3
@PgBiel
fix tests by using 'files'
39ac8fe
@lpil @PgBiel
Remove some indentation
7a582d7
@giacomocavalieri @PgBiel
code action to turn into use
8d268f3
@giacomocavalieri @PgBiel
CHANGELOG
a3db9a2
@giacomocavalieri @PgBiel
fix small indentation bug
905482f
@giacomocavalieri @PgBiel
rename action
95c0beb
@PgBiel PgBiel marked this pull request as ready for review January 20, 2025 01:37
@PgBiel PgBiel merged commit 0295a45 into main Jan 20, 2025
17 checks passed
@PgBiel PgBiel mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't FFI with Nix files in subdirectories