Fix/Recurring donation list amount, keys and GIV donations

[kkatusic]

Summary by CodeRabbit

• New Features

  • Enhanced handling of Giveth donation streams to verify existing streams before updates.
  • Improved rendering performance with more unique keys for token and stream components.

• Bug Fixes

  • Updated formatting for very small donation amounts for better user experience.

• Chores

  • Removed and commented out the configuration for "Coinbase Wrapped BTC" in production settings.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 23, 2024 8:23pm

[coderabbitai]

Walkthrough

This pull request encompasses modifications across multiple files in the donation and token selection components. The changes primarily focus on improving key uniqueness in React component rendering, enhancing donation stream handling, and refining number formatting. The updates include modifications to the SelectTokenModal components for one-time and recurring donations, updates to the production configuration, and a small change in the number formatting helper function.

Changes

File	Change Summary
src/components/views/donate/OneTime/SelectTokenModal/SelectTokenModal.tsx	Updated TokenInfo component's key prop from token.symbol to token.address for unique token identification
src/components/views/donate/Recurring/RecurringDonationModal/RecurringDonationModal.tsx	Added logic to check for existing Giveth donation streams before creating new ones
src/components/views/donate/Recurring/SelectTokenModal/SelectTokenModal.tsx	Enhanced key uniqueness for StreamInfo and TokenInfo components by combining multiple identifiers
src/config/production.tsx	Commented out and modified the configuration for "Coinbase Wrapped BTC" super token
src/helpers/number.ts	Added conditional check to return '< 0.01' for very small donation amounts

Suggested labels

code-review

Suggested reviewers

• CarlosQ96
• mateodaza

Possibly related PRs

• Hotfix - fix stellar doante card UI #4734: Similar modifications to TokenInfo component rendering logic
• Fix some UI stuff for stellar feature #4700: Updates to SelectTokenInnerModal component's key properties
• Recurring donations setup on Base #4889: GraphQL query updates for project-related data

Poem

🐰 A Rabbit's Ode to Code Refinement 🔧

Keys now dance with precision bright,
Tokens tagged with addresses' might,
Streams flow smooth, numbers gleam clear,
Refactoring brings the coder's cheer!

Hop, hop, hooray! 🎉

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/helpers/number.ts (1)

56-58: Consider handling small amounts as numeric types rather than string comparisons.
The direct string comparison for "<0.000001" is somewhat brittle. If future changes alter the string representation, this condition might break. Converting to a numeric value (e.g., via parseFloat) and then comparing against a threshold can improve maintainability.

src/components/views/donate/Recurring/RecurringDonationModal/RecurringDonationModal.tsx (1)

343-358: Refactor repeated stream retrieval logic.
This block smartly checks the network for an existing flow when no local record is found. To keep your code DRY, consider extracting local vs. remote checks into a helper so the stream lookup logic is consistent across the codebase.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cad8f44 and 5da3ade.

📒 Files selected for processing (5)

• src/components/views/donate/OneTime/SelectTokenModal/SelectTokenModal.tsx (1 hunks)
• src/components/views/donate/Recurring/RecurringDonationModal/RecurringDonationModal.tsx (1 hunks)
• src/components/views/donate/Recurring/SelectTokenModal/SelectTokenModal.tsx (3 hunks)
• src/config/production.tsx (1 hunks)
• src/helpers/number.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/config/production.tsx

🔇 Additional comments (3)

src/components/views/donate/Recurring/SelectTokenModal/SelectTokenModal.tsx (2)

142-142: Good move to enhance key uniqueness.
Using both tokenId and token.symbol (or token.id) in the key helps React better track changes for the StreamInfo component.

---

166-166: Ensuring key uniqueness with token ID, symbol, and chain ID.
This strongly reduces collisions even if multiple tokens share the same ID or symbol on different chains.

src/components/views/donate/OneTime/SelectTokenModal/SelectTokenModal.tsx (1)

255-255: Increasing key uniqueness by using token.address.
Since token addresses are unique, this is an excellent way to avoid collisions when rendering lists.

[mateodaza]

LGTM