Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors from event flushing #2681

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

gregberge
Copy link
Contributor

A fetch error does not mean a wrong status code it means the fetch cannot be done because of CORS or connection. So we ignore it.

Fix GITBOOK-OPEN-1W8D
Fix GITBOOK-OPEN-1W95
Fix GITBOOK-OPEN-1W8R
Fix GITBOOK-OPEN-1W8E
Fix GITBOOK-OPEN-1W9N

A fetch error does not mean a wrong status code it means the fetch cannot be done because of CORS or connection. So we ignore it.

Fix GITBOOK-OPEN-1W8D
Fix GITBOOK-OPEN-1W95
Fix GITBOOK-OPEN-1W8R
Fix GITBOOK-OPEN-1W8E
Fix GITBOOK-OPEN-1W9N
Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: d99d723

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 7, 2025

GitBook Preview
Latest commit: https://8beabcec.gitbook-open.pages.dev
PR: https://pr2681.gitbook-open.pages.dev

Copy link

argos-ci bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 138 changed Jan 7, 2025, 2:34 PM

@gregberge gregberge merged commit d66c184 into main Jan 7, 2025
9 checks passed
@gregberge gregberge deleted the ignore-errors-from-event-flush branch January 7, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants