Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToC not re-rendering when linking to a variant from SearchResults #2366

Conversation

scazan
Copy link
Contributor

@scazan scazan commented Jul 3, 2024

When navigating between variants/spaces from search results, we load the correct page but the ToC is not re-rendered as it is a SSR component. This PR removes the client side routing from the search results when you are viewing results.

Copy link

argos-ci bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 8 changed Jul 3, 2024, 10:21 AM

@scazan scazan marked this pull request as ready for review July 3, 2024 09:40
@scazan scazan force-pushed the scottcazan/rnd-4078-table-of-contents-is-not-updating-when-switching-between branch from dd96181 to 9f5b3f7 Compare July 3, 2024 10:15
@scazan scazan merged commit 4cf9cdd into main Jul 3, 2024
13 of 15 checks passed
@scazan scazan deleted the scottcazan/rnd-4078-table-of-contents-is-not-updating-when-switching-between branch July 3, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants