Skip to content

Commit

Permalink
Merge pull request #867 from pascalberger/FixArgumentParsing2
Browse files Browse the repository at this point in the history
Fix argument parsing
  • Loading branch information
gep13 committed May 18, 2016
2 parents 6308f89 + 86bfac3 commit 28b1572
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions src/GitVersionExe.Tests/ArgumentParserTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -291,4 +291,12 @@ public void log_path_can_contain_forward_slash()
var arguments = ArgumentParser.ParseArguments("-l /some/path");
arguments.LogFilePath.ShouldBe("/some/path");
}

[Test]
public void boolean_argument_handling()
{
var arguments = ArgumentParser.ParseArguments("/nofetch /updateassemblyinfo true");
arguments.NoFetch.ShouldBe(true);
arguments.UpdateAssemblyInfo.ShouldBe(true);
}
}
2 changes: 1 addition & 1 deletion src/GitVersionExe/ArgumentParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ static bool IsBooleanArgument(string switchName)
"nofetch"
};

return booleanArguments.Contains(switchName, StringComparer.OrdinalIgnoreCase);
return booleanArguments.Contains(switchName.Substring(1), StringComparer.OrdinalIgnoreCase);
}
}
}

0 comments on commit 28b1572

Please sign in to comment.