Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use CRS operations before initializing QgsApplication #60

Merged
merged 3 commits into from
May 20, 2024

Conversation

Joonalai
Copy link
Contributor

Fixes #56 by not using any QgsCoordinateReferenceSystem before initialiszing QgsApplication.

@Joonalai Joonalai force-pushed the 56-fix-invalid-crs branch 2 times, most recently from 35f3255 to 369b7dc Compare April 26, 2024 08:17
@Joonalai
Copy link
Contributor Author

Joonalai commented Apr 26, 2024

@LKajan could you review this and maybe make another release afterwards?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 57.25%. Comparing base (d5227a4) to head (369b7dc).

Files Patch % Lines
src/pytest_qgis/utils.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   57.66%   57.25%   -0.41%     
==========================================
  Files           7        7              
  Lines         496      496              
==========================================
- Hits          286      284       -2     
- Misses        210      212       +2     
Flag Coverage Δ
pytest 57.25% <0.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LKajan
Copy link
Contributor

LKajan commented Apr 30, 2024

Thanks for this PR!
I'm a bit busy right now, but I'll check this out in the next couple of days. I'll make a release then.

Copy link
Contributor

@LKajan LKajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This indeed is a weird case.

tests/test_crs.py Outdated Show resolved Hide resolved
@Joonalai Joonalai force-pushed the 56-fix-invalid-crs branch 5 times, most recently from 9b66a09 to 3db953c Compare May 13, 2024 18:48
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@LKajan LKajan force-pushed the 56-fix-invalid-crs branch from 3db953c to 3fa959b Compare May 20, 2024 18:05
@LKajan LKajan merged commit d782092 into GispoCoding:main May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRS Issue in the tests
3 participants