Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed boolean indexer mismatching issue #2071

Conversation

kevinmessiaen
Copy link
Member

@kevinmessiaen kevinmessiaen commented Nov 12, 2024

Description

Issue

The boolean indexer of the test_output_in_range is mismatching the sliced dataset.

Solution

Since we want to keep the original indexes for debugging purpose, to solution was to reindex the boolean indexer used as mask to the sliced dataset index

Related Issue

#2061

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

@kevinmessiaen kevinmessiaen force-pushed the 2061-test-output-in-range-indexing-error-while-using-slicing-function-for-classification-problem branch from 386cc8f to 09a7ee3 Compare November 12, 2024 10:44
@kevinmessiaen kevinmessiaen merged commit 8e2fac6 into main Nov 12, 2024
17 checks passed
@kevinmessiaen kevinmessiaen deleted the 2061-test-output-in-range-indexing-error-while-using-slicing-function-for-classification-problem branch November 12, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Test output in range - indexing error while using slicing function for classification problem
2 participants