Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-2135] Show warning if dependencies or python versions are mismatched #1620

Conversation

Inokinoki
Copy link
Member

@Inokinoki Inokinoki commented Nov 20, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Copy link

linear bot commented Nov 20, 2023

GSK-2135 Show warning if dependencies or Python versions are mismatched

We are facing failed unpickle issue due to version mismatch of either versions of dependencies:

  File "/Users/matteo/Code/giskard/giskard/ml_worker/testing/registry/giskard_test.py", line 77, in load
    func = pickle.load(f)
           ^^^^^^^^^^^^^^
  File "pydantic/main.py", line 417, in pydantic.main.BaseModel.__setstate__
KeyError: '__fields_set__'

or versions of Python:

image.png

Regarding that users should have the right to upgrade everything, we should notice them in that case.

@Inokinoki Inokinoki changed the title WIP [GSK-2135] show warning if dependencies or python versions are mismatched [GSK-2135] show warning if dependencies or python versions are mismatched Nov 22, 2023
@Inokinoki Inokinoki marked this pull request as ready for review November 22, 2023 22:19
@Inokinoki Inokinoki changed the title [GSK-2135] show warning if dependencies or python versions are mismatched [GSK-2135] Show warning if dependencies or python versions are mismatched Nov 22, 2023
Copy link
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should leverage the Python version in meta to give more insight to the user when raising the exception

giskard/ml_worker/exceptions/giskard_exception.py Outdated Show resolved Hide resolved
giskard/ml_worker/exceptions/giskard_exception.py Outdated Show resolved Hide resolved
…-2135-show-warning-if-dependencies-or-python-versions-are
@Inokinoki Inokinoki enabled auto-merge (squash) November 28, 2023 15:01
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.0% 81.0% Coverage
0.0% 0.0% Duplication

@Inokinoki Inokinoki merged commit cc29880 into main Nov 28, 2023
17 checks passed
@Inokinoki Inokinoki deleted the feature/gsk-2135-show-warning-if-dependencies-or-python-versions-are branch November 28, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants