Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce not given and apply it to dataset's target #1612

Merged
merged 21 commits into from
Nov 29, 2023
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b9c59a1
Introduce not given and apply it to dataset's target
kevinmessiaen Nov 15, 2023
15c8ecf
Fixed typo
kevinmessiaen Nov 15, 2023
0e2e4f2
Added test to validate explicit target as None
kevinmessiaen Nov 15, 2023
57ecaf3
Fixed test where trying to assign value to a @property
kevinmessiaen Nov 16, 2023
3b877c5
Actually test for no warning being raised
kevinmessiaen Nov 16, 2023
21bf1b0
Code optimization
kevinmessiaen Nov 16, 2023
2a52a37
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 16, 2023
f7ec53b
Fixed compatibility issue with Python 3.9 due to usage of `|`
kevinmessiaen Nov 16, 2023
9eb16ab
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
rabah-khalek Nov 16, 2023
c464a55
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
rabah-khalek Nov 17, 2023
7d9df77
Removed check for model type to ignore target warnings
kevinmessiaen Nov 20, 2023
d4a7816
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 20, 2023
906f4ff
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 24, 2023
24d15a3
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 27, 2023
438ca6d
Moved target validation from model to dataset
kevinmessiaen Nov 27, 2023
ee7b5f7
Updated documentation and notebook
kevinmessiaen Nov 27, 2023
454e1cb
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 28, 2023
d440242
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 29, 2023
49d10bc
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 29, 2023
2dab169
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
rabah-khalek Nov 29, 2023
4f179f0
Merge branch 'main' into feature/gsk-2118-introduce-not_given-type-2
kevinmessiaen Nov 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions giskard/core/model_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
from giskard.datasets.base import Dataset
from giskard.ml_worker.testing.registry.slicing_function import SlicingFunction
from giskard.models.base import BaseModel, WrapperModel
from .dataset_validation import validate_optional_target
from ..utils import fullname
from ..utils.analytics_collector import analytics, get_dataset_properties, get_model_properties
from .dataset_validation import validate_optional_target


@configured_validate_arguments
def validate_model(model: BaseModel, validate_ds: Optional[Dataset] = None, print_validation_message: bool = True):
try:
if model.meta.model_type != SupportedModelTypes.TEXT_GENERATION and validate_ds is not None:
if validate_ds is not None:
validate_optional_target(validate_ds)
kevinmessiaen marked this conversation as resolved.
Show resolved Hide resolved
_do_validate_model(model, validate_ds)
except (ValueError, TypeError) as err:
Expand Down