chore(dogfooding) improve desktop layout #846
Open
+227
−205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Describe why we are making this change
After making PR #845 I also wanted to make the app usable on wider displays. On multiple screens the layout breaks when you have a wide window.
🛠 Implementation details
Describe the implementation
On the home screen and the login screen I mainly made sure that the logo is not getting huge. I set the max width of that screen to 500px as the web implementation also doesn't get much wider than that. But we can discuss that value.
The lobby had the buttons weirdly aligned to the right, I added that to the max width that was already there.
The buttons on the call screen are very close to the bottom, so I added a bit of padding there.
🎨 UI Changes
Add relevant screenshots
🧪 Testing
Explain how this change can be tested (or why it can't be tested)
To test the desktop changes you need to combine this branch with #845 to have it running on macos.
It should not effect smaller screens, but could be good to test on mobile devices as well.
☑️Contributor Checklist
General
☑️Reviewer Checklist