Fix updating channel's preview message when coming back to online #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
added
🐞 Bug
laevandus
commented
Jan 28, 2025
| // Ignore cache when inserted (but not yet saved) object id is present | ||
| guard !objectIds.contains(where: { $0.isTemporaryID }) else { return false } | ||
| // Context has pending inserted or deleted objects of this type (can affect ids returned by the fetch request) | ||
| guard !insertedObjects.contains(where: { $0 is T }) && !deletedObjects.contains(where: { $0 is T }) else { return false } |
There was a problem hiding this comment.
Theoretically speaking even updatedObjects could change results, but this will take away the benefit of the cache. Based on the history, it was added for speeding up channel list payload writes.
laevandus
force-pushed
the
fix/updating-preview-message
branch
from
20c98c7 to
4c1f1b3
Compare
SDK Size
|
SDK Performance
|
|
nuno-vieira
approved these changes
Jan 28, 2025
SDK Size
|
testableapple
added
🧪 QAing
and removed
🤞 Ready For QA
# Conflicts: # CHANGELOG.md
martinmitrevski
approved these changes
Feb 3, 2025
|
@testableapple found that in some cases the preview message can end up being nil and then the channel list shows "No messages" as the preview. Reproduced it once, but don't know which code path triggers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves IOS-680
🎯 Goal
Channel's preview message did not update when coming back online
📝 Summary
🛠 Implementation
Ignore cached results if there are new objects inserted or deleted for that type.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo