fix: mark channel read for all incoming unread messages #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
oliverlaz,
myandrienko,
szuperaz and
arnautov-anton
|
Size Change: -86 B (-0.01%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2622 +/- ##
========================================
Coverage 81.12% 81.13%
========================================
Files 448 448
Lines 9464 9462 -2
Branches 2312 2223 -89
========================================
- Hits 7678 7677 -1
- Misses 1423 1674 +251
+ Partials 363 111 -252 ☔ View full report in Codecov by Sentry. |
szuperaz
reviewed
Jan 28, 2025
szuperaz
approved these changes
Jan 28, 2025
oliverlaz
approved these changes
Jan 28, 2025
|
🎉 This PR is included in version 12.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Prevent marking channel based on unread count. Marking channel read based on unread count lead to a paradoxical situation when user that sent the last message in a channel was seen by others as not having read a channel for some time despite the authorship of the last message in the channel. In other words, the last read data for a given user were not updated unless the user had unread count > 0 at some point.
Fixes REACT-252
🛠 Implementation details
Remove unread count from the conditions to mark a channel read and instead base the decision on the last message in the channel compared to the last read message of a user.