-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to React v19 #2615
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2615 +/- ##
==========================================
- Coverage 81.09% 81.00% -0.09%
==========================================
Files 449 449
Lines 9489 9489
Branches 2231 2231
==========================================
- Hits 7695 7687 -8
- Misses 1684 1686 +2
- Partials 110 116 +6 ☔ View full report in Codecov by Sentry. |
import '@testing-library/jest-dom'; | ||
import renderer from 'react-test-renderer'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-test-renderer
has been deprecated. Therefore many snapshots had to be changed.
Size Change: +7.94 kB (+0.67%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
@@ -1,4 +1,4 @@ | |||
import { act, renderHook } from '@testing-library/react-hooks'; | |||
import { act, renderHook } from '@testing-library/react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@testing-library/react-hooks does not seem to be continued - it has not been updated to be compatible with React v19.
caaeffe
to
20e4c90
Compare
# Conflicts: # package.json
🎉 This PR is included in version 12.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In order to be able to run stream-chat-react with React v19 you need to allow for our dependency react-markdown to install its own version of React types. Add the following section to your package.json: "resolutions": {
"react-markdown/@types/react": "^18.0.0"
} After that do not forget to remove and re-install |
Tested locally with app running on
Fixes React-253