fix: disable SuggestionList during text composition #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +173 B (0%) Total Size: 1.67 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Dec 6, 2023
arnautov-anton
force-pushed
the
fix/suggestion-list-disabled-composing
branch
from
e9bb0a6 to
474a51f
Compare
MartinCupela
approved these changes
Dec 11, 2023
arnautov-anton
force-pushed
the
fix/suggestion-list-disabled-composing
branch
from
474a51f to
cc384d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2205 +/- ##
=======================================
Coverage 83.82% 83.83%
=======================================
Files 311 311
Lines 7129 7131 +2
Branches 1902 1901 -1
=======================================
+ Hits 5976 5978 +2
Misses 985 985
Partials 168 168 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
## [11.1.2](v11.1.1...v11.1.2) (2023-12-13) ### Bug Fixes * disable SuggestionList during text composition ([#2205](#2205)) ([614bc99](614bc99)) * mark as read messages sent by current user ([#2211](#2211)) ([38f2363](38f2363)) * schedule cooldown removal from useCooldownTimer hook instead of CooldownTimer ([#2208](#2208)) ([9523b45](9523b45)) * show image fallbacks in image gallery modal ([#2212](#2212)) ([5ac95a1](5ac95a1)) ### Chores * **deps:** bump @stream-io/stream-chat-css from v4.1.0 to v4.2.0 ([ff554ad](ff554ad))
|
🎉 This PR is included in version 11.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
arnautov-anton
added a commit
that referenced
this pull request
Jan 10, 2024
### 🎯 Goal Disables `SuggestionList` component when text composition (with Korean and Japanese keyboard inputs) is active to prevent text duplication on submission. During text composition:  After text composition: 
github-actions bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
## [10.22.3](v10.22.2...v10.22.3) (2024-01-10) ### Bug Fixes * disable SuggestionList during text composition ([#2205](#2205)) ([502c588](502c588))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Disables
SuggestionListcomponent when text composition (with Korean and Japanese keyboard inputs) is active to prevent text duplication on submission.During text composition:
After text composition:
