Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i227] fix crash in audio player after relogin #5120

Merged
merged 3 commits into from
Dec 20, 2023
Merged

[i227] fix crash in audio player after relogin #5120

merged 3 commits into from
Dec 20, 2023

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Dec 18, 2023

🎯 Goal

Closes:

🛠 Implementation details

In addition to the crash fix, other minor bugs were fixed as well:

  • reply view was showing incorrect duration value (always showing zero)
  • seekTo was using incorrect dimension (seconds instead of milliseconds)

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review December 18, 2023 22:24
@kanat kanat requested a review from a team as a code owner December 18, 2023 22:24
@kanat kanat added bug Something isn't working ui-components core v6 labels Dec 18, 2023
@kanat kanat enabled auto-merge (squash) December 20, 2023 15:59
@kanat kanat merged commit 7511e17 into develop Dec 20, 2023
7 checks passed
@kanat kanat deleted the bugfix/crash-audio-player branch December 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNovak DanielNovak DanielNovak approved these changes

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core ui-components v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanat @DanielNovak @aleksandar-apostolov