Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [UI/UX] Max-width for attached files thumbnails #4546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

camillemonchicourt
Copy link
Member

Description

Not sure I made it in the right CSS file.
And I initially thought it was rather to do in Django-mapentity, but this CSS class was only used in Geotrek-admin.

It fixes a max-width to images thumbnails in attached files list.

For Youtube links attached files :

Before :

image

After :

image

For external images :

Before :

image

After :

image

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (5c6c020) to head (f929509).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4546   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         270      270           
  Lines       21534    21534           
=======================================
  Hits        21205    21205           
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 27, 2025

Geotrek-admin    Run #11293

Run Properties:  status check passed Passed #11293  •  git commit 0e75acbe35 ℹ️: Merge f9295097177410912a8a6c9dc207eb93580b5ba2 into 2ff77b6d9c22ec91cdaf1b5be76e...
Project Geotrek-admin
Branch Review refs/pull/4546/merge
Run status status check passed Passed #11293
Run duration 02m 02s
Commit git commit 0e75acbe35 ℹ️: Merge f9295097177410912a8a6c9dc207eb93580b5ba2 into 2ff77b6d9c22ec91cdaf1b5be76e...
Committer Camille Monchicourt
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants