Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated code in django 5.2 #4536

Merged
merged 4 commits into from
Feb 23, 2025
Merged

Delete deprecated code in django 5.2 #4536

merged 4 commits into from
Feb 23, 2025

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (b4ad9df) to head (bd5c0f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4536   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         270      270           
  Lines       21523    21534   +11     
=======================================
+ Hits        21194    21205   +11     
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 23, 2025

Geotrek-admin    Run #11264

Run Properties:  status check passed Passed #11264  •  git commit 6a323e477f ℹ️: Merge bd5c0f7f7a3343fbc0444f853795a7564c89832c into b4ad9dfecdc17e0ba440e09c0599...
Project Geotrek-admin
Branch Review refs/pull/4536/merge
Run status status check passed Passed #11264
Run duration 02m 06s
Commit git commit 6a323e477f ℹ️: Merge bd5c0f7f7a3343fbc0444f853795a7564c89832c into b4ad9dfecdc17e0ba440e09c0599...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos marked this pull request as ready for review February 23, 2025 21:09
@submarcos submarcos merged commit 5c6c020 into master Feb 23, 2025
26 checks passed
@submarcos submarcos deleted the pre_django_5.2 branch February 23, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant