Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post audit improvements #66

Merged
merged 304 commits into from
Nov 3, 2023
Merged

Post audit improvements #66

merged 304 commits into from
Nov 3, 2023

Conversation

geode-main
Copy link
Member

No description provided.

geode-main
geode-main commented Mar 19, 2023
View reviewed changes
Copy link
Member Author

@geode-main geode-main left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues fixed according to the report.
Requires little chores.

crashbandicoott
crashbandicoott previously approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@crashbandicoott crashbandicoott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

crashbandicoott
crashbandicoott previously approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@crashbandicoott crashbandicoott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crashbandicoott crashbandicoott self-requested a review March 20, 2023 16:21
crashbandicoott and others added 27 commits November 1, 2023 00:37
@crashbandicoott
Fix: Audit 5.5
00b046b
@crashbandicoott
Fix: Audit 5.7
f379cb3
@crashbandicoott
Fix: Audit 5.3, 5.4
4140f75
@crashbandicoott
Fix: Audit 5.8
f881cc0
@crashbandicoott
Fix: Audit 5.9
3cbc89a
@crashbandicoott
Fix: Audit 5.2
a6cc537
@crashbandicoott
Fix: Audit 5.1
b36899d
@crashbandicoott
Fix: solve bugs on WithdrawalModuleLib
f584df9
@crashbandicoott
Test: Fix tests according to audit fixes, still have room for updates
241ed81
@crashbandicoott
Test: improve transferRequest tests
af0159c
@crashbandicoott
Refactor: add brackets over else revert statement in authenticate
c6774d6
@crashbandicoott
Refactor: improve gas with combining loops and get rid of extra if st…
d3cec9e 
…atement in _distributeFees
@crashbandicoott
Audit: adding external Diligence audit report for withdrawal contract
aaad917
@geode-main
Chores: rename audit files, clear readme
d5e3d3a
@geode-main
Feat: improve gas on getValidator calls on processValidators()
af4b943
@geode-main
Feat: add DEFAULT_ADMIN_ROLE back in case it is useful in the future
ffea53b
@geode-main
Merge pull request #80 from Geodefi/upgradability-tests
4a72a36 
Upgradability tests
@geode-main
Merge pull request #79 from Geodefi/prep-diligence-audit-3
1c43d9d 
Prepare for diligence audit
@geode-main
Merge pull request #78 from Geodefi/shieldify-audit-2-fixes
4f04b03 
Shieldify audit-2 fixes
@geode-main
Merge pull request #77 from Geodefi/SC2-withdrawal-module
505d04a 
Sc2 withdrawal module
@geode-main
Merge pull request #81 from Geodefi/SC1-rebase-middleware
5ffe26c 
Sc1 rebase middleware
@geode-main
Merge branch 'new-arch-fix' into shieldify-audit-improvements
d2df907
@geode-main
Merge pull request #82 from Geodefi/shieldify-audit-improvements
a653706 
Shieldify audit improvements
@geode-main
Merge pull request #73 from Geodefi/new-arch-fix
67a26b6 
New arch fix
@geode-main
Merge pull request #71 from Geodefi/new-arch-test
940652a 
New architecture tests
@geode-main
Merge pull request #70 from Geodefi/new-arch
b31a1b3 
new Architecture
@geode-main
Merge pull request #68 from Geodefi/67-modular-architecture
f186600 
Modular architecture
@geode-main
Copy link
Member Author

geode-main commented Nov 3, 2023 •
edited
Loading

LGTM :)

@crashbandicoott
Copy link
Member

LGTM 🤞

@geode-main geode-main merged commit dd3a42c into dev Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crashbandicoott crashbandicoott crashbandicoott left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geode-main @crashbandicoott