Add tests with DMD / LDC master #87
Conversation
|
Or perhaps I should just switch to Github Actions to have cross-platform testing... |
Geod24
force-pushed
the
test-with-upstream
branch
4 times, most recently
from
850f8f1 to
bc0bc4d
Compare
|
Well LDC still has the regression we caught: ldc-developers/ldc#3501 (comment) |
Geod24
force-pushed
the
test-with-upstream
branch
2 times, most recently
from
ed12ac4 to
e2b8ae3
Compare
|
Updated with a workaround for the Windows ICE we found (yay): ldc-developers/ldc#3517 (comment) |
what the.. |
| @@ -103,6 +103,7 @@ module geod24.LocalRest; | |||
|
|
|||
| static import C = geod24.concurrency; | |||
There was a problem hiding this comment.
our of spawn => out of spawn
There was a problem hiding this comment.
What ? Where is this written ?
There was a problem hiding this comment.
In the commit message. Sorry github makes it not easy to comment on the actual commit message.
.github/workflows/main.yaml
Outdated
| fail-fast: false | ||
| matrix: | ||
| os: [ ubuntu-18.04, macOS-10.15, windows-2019 ] | ||
| dc: [ ldc-master, dmd-master, ldc-latest, dmd-latest, ldc-1.17.0, dmd-2.088.1 ] |
There was a problem hiding this comment.
How about gdc? We don't want to support it yet?
There was a problem hiding this comment.
Riiiiiight, I'll add it back
|
I remember typeinfo in DLLs on Windows being a problem.. 10 years ago. :D |
Geod24
force-pushed
the
test-with-upstream
branch
3 times, most recently
from
1040b92 to
4d1e3cc
Compare
|
I cannot reproduce the bug. :/ I tried DMD |
|
Correction I only have 8GB of RAM, so that can't be it. |
This was reported by the LDC developers as being the source of an ICE we are seeing on Windows.
Using Github Actions allows us to have testing on all three platforms. Additionally, the minimum version have been raised. Versions lower than 2.088.1 / LDC 1.17.0 do not work on Mac OSX 10.15 (Catalina) because of the removal of a private API Druntime was using. Additionally, we caught a few regressions which were only recently fixed.
Geod24
force-pushed
the
test-with-upstream
branch
from
56fc5b2 to
1317e7d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.x.x #87 +/- ##
==========================================
+ Coverage 94.62% 94.65% +0.02%
==========================================
Files 4 4
Lines 875 879 +4
==========================================
+ Hits 828 832 +4
Misses 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Done in #135 |
No description provided.